Make @Path of UNIX chr device source optional

[libvirt] [libvirt-go-xml PATCH] Make @Path of UNIX chr device source optional

Posted by Erik Skultety 5 years, 1 month ago

According to the libvirt RNG schema, @path is an optional attribute for
the character source element, so we should be okay if it was omitted.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
---
 domain.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/domain.go b/domain.go
index a964cc8..a1a3fcb 100644
--- a/domain.go
+++ b/domain.go
@@ -735,7 +735,7 @@ type DomainChardevSourceTCP struct {
 
 type DomainChardevSourceUNIX struct {
 	Mode      string                        `xml:"mode,attr,omitempty"`
-	Path      string                        `xml:"path,attr"`
+	Path      string                        `xml:"path,attr,omitempty"`
 	Reconnect *DomainChardevSourceReconnect `xml:"reconnect"`
 	SecLabel  []DomainDeviceSecLabel        `xml:"seclabel"`
 }
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [libvirt-go-xml PATCH] Make @Path of UNIX chr device source optional

Posted by Daniel P. Berrangé 5 years, 1 month ago

On Wed, Mar 13, 2019 at 09:58:52AM +0100, Erik Skultety wrote:
> According to the libvirt RNG schema, @path is an optional attribute for
> the character source element, so we should be okay if it was omitted.
> 
> Signed-off-by: Erik Skultety <eskultet@redhat.com>
> ---
>  domain.go | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list