[PATCH 2/4] libxl: make use of e820_host feature

Marek Marczykowski-Górecki posted 4 patches 5 years, 10 months ago
There is a newer version of this series
[PATCH 2/4] libxl: make use of e820_host feature
Posted by Marek Marczykowski-Górecki 5 years, 10 months ago
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 src/libxl/libxl_conf.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index b3f67f8..05d671b 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -692,6 +692,20 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
             b_info->u.pv.kernel = g_strdup(def->os.kernel);
         }
         b_info->u.pv.ramdisk = g_strdup(def->os.initrd);
+
+        if (def->features[VIR_DOMAIN_FEATURE_XEN] == VIR_TRISTATE_SWITCH_ON) {
+            switch ((virTristateSwitch) def->xen_features[VIR_DOMAIN_XEN_E820_HOST]) {
+                case VIR_TRISTATE_SWITCH_ON:
+                    libxl_defbool_set(&b_info->u.pv.e820_host, true);
+                    break;
+                case VIR_TRISTATE_SWITCH_OFF:
+                    libxl_defbool_set(&b_info->u.pv.e820_host, false);
+                    break;
+                case VIR_TRISTATE_SWITCH_ABSENT:
+                case VIR_TRISTATE_SWITCH_LAST:
+                    break;
+            }
+        }
     }
 
     /* only the 'xen' balloon device model is supported */
-- 
git-series 0.9.1


Re: [PATCH 2/4] libxl: make use of e820_host feature
Posted by Jim Fehlig 5 years, 10 months ago
On 4/13/20 2:10 PM, Marek Marczykowski-Górecki wrote:
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim

> ---
>   src/libxl/libxl_conf.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index b3f67f8..05d671b 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -692,6 +692,20 @@ libxlMakeDomBuildInfo(virDomainDefPtr def,
>               b_info->u.pv.kernel = g_strdup(def->os.kernel);
>           }
>           b_info->u.pv.ramdisk = g_strdup(def->os.initrd);
> +
> +        if (def->features[VIR_DOMAIN_FEATURE_XEN] == VIR_TRISTATE_SWITCH_ON) {
> +            switch ((virTristateSwitch) def->xen_features[VIR_DOMAIN_XEN_E820_HOST]) {
> +                case VIR_TRISTATE_SWITCH_ON:
> +                    libxl_defbool_set(&b_info->u.pv.e820_host, true);
> +                    break;
> +                case VIR_TRISTATE_SWITCH_OFF:
> +                    libxl_defbool_set(&b_info->u.pv.e820_host, false);
> +                    break;
> +                case VIR_TRISTATE_SWITCH_ABSENT:
> +                case VIR_TRISTATE_SWITCH_LAST:
> +                    break;
> +            }
> +        }
>       }
>   
>       /* only the 'xen' balloon device model is supported */
>