storage_file: Fix probing of backing images with 'data_file' with auto-probed format

[PATCH 0/2] storage_file: Fix probing of backing images with 'data_file' with auto-probed format

Peter Krempa via Devel posted 2 patches 2 weeks, 5 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1785879137.git.pkrempa@redhat.com

src/storage_file/storage_source.c              |   3 ++-
tests/virstoragetest.c                         |   7 ++++++-
.../images/qcow2_datafile-auto.qcow2           | Bin 0 -> 196616 bytes
3 files changed, 8 insertions(+), 2 deletions(-)
create mode 100644 tests/virstoragetestdata/images/qcow2_datafile-auto.qcow2

Expand all Fold all

[PATCH 0/2] storage_file: Fix probing of backing images with 'data_file' with auto-probed format

Posted by Peter Krempa via Devel 2 weeks, 5 days ago

Patch 1 adds an counter-example test and patch 2 then fixes the bug.

Peter Krempa (2):
  virstoragetest: Add example of a qcow2 image with a backing image
    pointing to a data_file without 'backing_format'
  virStorageSourceGetMetadataRecurse: Fix format probing exception for
    images with 'data_file'

 src/storage_file/storage_source.c              |   3 ++-
 tests/virstoragetest.c                         |   7 ++++++-
 .../images/qcow2_datafile-auto.qcow2           | Bin 0 -> 196616 bytes
 3 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 tests/virstoragetestdata/images/qcow2_datafile-auto.qcow2

-- 
2.55.0

Re: [PATCH 0/2] storage_file: Fix probing of backing images with 'data_file' with auto-probed format

Posted by Ján Tomko via Devel 1 week, 2 days ago

On a Tuesday in 2026, Peter Krempa via Devel wrote:
>Patch 1 adds an counter-example test and patch 2 then fixes the bug.
>
>Peter Krempa (2):
>  virstoragetest: Add example of a qcow2 image with a backing image
>    pointing to a data_file without 'backing_format'
>  virStorageSourceGetMetadataRecurse: Fix format probing exception for
>    images with 'data_file'
>
> src/storage_file/storage_source.c              |   3 ++-
> tests/virstoragetest.c                         |   7 ++++++-
> .../images/qcow2_datafile-auto.qcow2           | Bin 0 -> 196616 bytes
> 3 files changed, 8 insertions(+), 2 deletions(-)
> create mode 100644 tests/virstoragetestdata/images/qcow2_datafile-auto.qcow2
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano