[v1] qemu: Fix CPU feature reporting on AMD CPUs

[PATCH 00/10] qemu: Fix CPU feature reporting on AMD CPUs

Jiri Denemark via Devel posted 10 patches 3 days, 4 hours ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1779876382.git.jdenemar@redhat.com

There is a newer version of this series

docs/manpages/virsh.rst          |   4 +-
include/libvirt/libvirt-domain.h |   2 +-
src/cpu/cpu.c                    |  33 +++++
src/cpu/cpu.h                    |  12 ++
src/cpu/cpu_x86.c                |  54 ++++++--
src/cpu/cpu_x86.h                |   4 +
src/libvirt-domain.c             |   7 +-
src/libvirt_private.syms         |   3 +
src/qemu/qemu_capabilities.c     | 223 ++++++++++++++++++++++---------
src/qemu/qemu_capabilities.h     |   7 +-
src/qemu/qemu_conf.c             |   6 +-
src/qemu/qemu_conf.h             |   3 +-
src/qemu/qemu_driver.c           |  15 +--
src/util/virhostcpu.c            |  16 ++-
src/util/virhostcpu.h            |   3 +
tests/domaincapstest.c           |   2 +-
tests/qemucpumock.c              |  22 +++
tools/virsh-host.c               |   2 +-
18 files changed, 319 insertions(+), 99 deletions(-)

Expand all Fold all

[PATCH 00/10] qemu: Fix CPU feature reporting on AMD CPUs

Posted by Jiri Denemark via Devel 3 days, 4 hours ago

See the last patch for detailed description.

Jiri Denemark (10):
  qemu_capabilities: Split virQEMUCapsFillDomainCPUCaps
  qemu: Move domain caps flags handling to
    virQEMUCapsFillDomainCPUHostModel
  qemu_capabilities: Use g_autoptr in virQEMUCapsInitHostCPUModel
  qemu_capabilities: Split conditions in virQEMUCapsInitHostCPUModel
  qemu_capabilities: Cache expanded CPU
  util: Publish and mock virHostCPUGetMSRFromKVM
  cpu_x86: Introduce virCPUx86DataAddMSR
  cpu: Introduce virCPUUpdateFeatures
  Clarify documentation of
    VIR_CONNECT_GET_DOMAIN_CAPABILITIES_EXPAND_CPU_FEATURES
  qemu_capabilities: Fix domain capabilities on AMD CPUs

 docs/manpages/virsh.rst          |   4 +-
 include/libvirt/libvirt-domain.h |   2 +-
 src/cpu/cpu.c                    |  33 +++++
 src/cpu/cpu.h                    |  12 ++
 src/cpu/cpu_x86.c                |  54 ++++++--
 src/cpu/cpu_x86.h                |   4 +
 src/libvirt-domain.c             |   7 +-
 src/libvirt_private.syms         |   3 +
 src/qemu/qemu_capabilities.c     | 223 ++++++++++++++++++++++---------
 src/qemu/qemu_capabilities.h     |   7 +-
 src/qemu/qemu_conf.c             |   6 +-
 src/qemu/qemu_conf.h             |   3 +-
 src/qemu/qemu_driver.c           |  15 +--
 src/util/virhostcpu.c            |  16 ++-
 src/util/virhostcpu.h            |   3 +
 tests/domaincapstest.c           |   2 +-
 tests/qemucpumock.c              |  22 +++
 tools/virsh-host.c               |   2 +-
 18 files changed, 319 insertions(+), 99 deletions(-)

-- 
2.54.0

Re: [PATCH 00/10] qemu: Fix CPU feature reporting on AMD CPUs

Posted by Jiří Denemark via Devel 2 days, 1 hour ago

On Wed, May 27, 2026 at 12:07:12 +0200, Jiri Denemark wrote:
> See the last patch for detailed description.
> 
> Jiri Denemark (10):
>   qemu_capabilities: Split virQEMUCapsFillDomainCPUCaps
>   qemu: Move domain caps flags handling to
>     virQEMUCapsFillDomainCPUHostModel
>   qemu_capabilities: Use g_autoptr in virQEMUCapsInitHostCPUModel
>   qemu_capabilities: Split conditions in virQEMUCapsInitHostCPUModel
>   qemu_capabilities: Cache expanded CPU
>   util: Publish and mock virHostCPUGetMSRFromKVM

Hmm, I mocked this function, but it won't really be used anywhere as
VIR_CONNECT_GET_DOMAIN_CAPABILITIES_EXPAND_CPU_FEATURES is not tested. I
will send v2 with the tests added.

Jirka