[PATCH v4 0/2] Fix VMWare domain tracking

Martin Kletzander via Devel posted 2 patches 2 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1778840347.git.mkletzan@redhat.com
NEWS.rst                                   | 10 +++++
docs/drvesx.rst                            | 24 ++++++++++++
src/esx/esx_driver.c                       | 43 +++++++++++++++-------
src/esx/esx_util.c                         | 11 ++++++
src/esx/esx_util.h                         |  1 +
src/esx/esx_vi.c                           | 32 ++++++++++++++--
src/esx/esx_vi.h                           |  3 ++
src/vmx/vmx.c                              | 12 +++++-
tests/vmx2xmldata/case-insensitive-1.xml   |  1 +
tests/vmx2xmldata/case-insensitive-2.xml   |  1 +
tests/vmx2xmldata/esx-in-the-wild-1.xml    |  1 +
tests/vmx2xmldata/esx-in-the-wild-10.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-11.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-12.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-13.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-14.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-15.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-16.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-17.xml   |  3 +-
tests/vmx2xmldata/esx-in-the-wild-2.xml    |  1 +
tests/vmx2xmldata/esx-in-the-wild-3.xml    |  1 +
tests/vmx2xmldata/esx-in-the-wild-4.xml    |  1 +
tests/vmx2xmldata/esx-in-the-wild-5.xml    |  3 +-
tests/vmx2xmldata/esx-in-the-wild-6.xml    |  3 +-
tests/vmx2xmldata/esx-in-the-wild-7.xml    |  3 +-
tests/vmx2xmldata/esx-in-the-wild-8.xml    |  3 +-
tests/vmx2xmldata/esx-in-the-wild-9.xml    |  3 +-
tests/vmx2xmldata/fusion-in-the-wild-1.xml |  1 +
tests/vmx2xmldata/gsx-in-the-wild-1.xml    |  1 +
tests/vmx2xmldata/gsx-in-the-wild-2.xml    |  1 +
tests/vmx2xmldata/gsx-in-the-wild-3.xml    |  1 +
tests/vmx2xmldata/gsx-in-the-wild-4.xml    |  1 +
32 files changed, 153 insertions(+), 33 deletions(-)
[PATCH v4 0/2] Fix VMWare domain tracking
Posted by Martin Kletzander via Devel 2 weeks, 1 day ago
v4:
- Add forgotten test XML changes
- Add explicit documentation about the UUID stability changing
- Do not mess up whitespaces in the NEWS

v3:
- https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XO3IJZKKGRQHDMBN2F27SUDKFO4NGP3M/
- Remove leftover comment
- Parse both UUIDs and leave the legacy one in <hwuuid>
- Fix the callback for VMX parsing

v2:
- https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ODGBRHHXD34EBDO3XJVQE5SWXL7VDHQ4/
- ESX driver has an opt-in for the legacy behaviour just in case anynone needs
  that, although hopefully that should not be the case.  The opt-in does not
  exist in the vmware driver or the vmx tests, there the v1 behaviour is kept in
  which vc.uuid is preferred, but uuid.bios is a fallback.

v1:
- https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WEKRADQVZ2CIBNNDRJWXHYQFDXR5MAOD/

Martin Kletzander (2):
  esx: Track VMs by instanceUuid instead of UUID
  NEWS: Add information about VMWare domains having different UUIDs

 NEWS.rst                                   | 10 +++++
 docs/drvesx.rst                            | 24 ++++++++++++
 src/esx/esx_driver.c                       | 43 +++++++++++++++-------
 src/esx/esx_util.c                         | 11 ++++++
 src/esx/esx_util.h                         |  1 +
 src/esx/esx_vi.c                           | 32 ++++++++++++++--
 src/esx/esx_vi.h                           |  3 ++
 src/vmx/vmx.c                              | 12 +++++-
 tests/vmx2xmldata/case-insensitive-1.xml   |  1 +
 tests/vmx2xmldata/case-insensitive-2.xml   |  1 +
 tests/vmx2xmldata/esx-in-the-wild-1.xml    |  1 +
 tests/vmx2xmldata/esx-in-the-wild-10.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-11.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-12.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-13.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-14.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-15.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-16.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-17.xml   |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-2.xml    |  1 +
 tests/vmx2xmldata/esx-in-the-wild-3.xml    |  1 +
 tests/vmx2xmldata/esx-in-the-wild-4.xml    |  1 +
 tests/vmx2xmldata/esx-in-the-wild-5.xml    |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-6.xml    |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-7.xml    |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-8.xml    |  3 +-
 tests/vmx2xmldata/esx-in-the-wild-9.xml    |  3 +-
 tests/vmx2xmldata/fusion-in-the-wild-1.xml |  1 +
 tests/vmx2xmldata/gsx-in-the-wild-1.xml    |  1 +
 tests/vmx2xmldata/gsx-in-the-wild-2.xml    |  1 +
 tests/vmx2xmldata/gsx-in-the-wild-3.xml    |  1 +
 tests/vmx2xmldata/gsx-in-the-wild-4.xml    |  1 +
 32 files changed, 153 insertions(+), 33 deletions(-)

-- 
2.54.0
Re: [PATCH v4 0/2] Fix VMWare domain tracking
Posted by Peter Krempa via Devel 2 weeks, 1 day ago
On Fri, May 15, 2026 at 12:28:03 +0200, Martin Kletzander via Devel wrote:
> v4:
> - Add forgotten test XML changes
> - Add explicit documentation about the UUID stability changing
> - Do not mess up whitespaces in the NEWS

Series [1]:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

[1]: Retaining the disclaimer about ignorance about ESX internals :)