[PATCH v3 0/2] Fix VMWare domain tracking

Martin Kletzander via Devel posted 2 patches an hour ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1778831362.git.mkletzan@redhat.com
NEWS.rst                                 |  9 +++++
docs/drvesx.rst                          |  9 +++++
src/esx/esx_driver.c                     | 43 ++++++++++++++++--------
src/esx/esx_util.c                       | 11 ++++++
src/esx/esx_util.h                       |  1 +
src/esx/esx_vi.c                         | 32 +++++++++++++++---
src/esx/esx_vi.h                         |  3 ++
src/vmx/vmx.c                            | 12 +++++--
tests/vmx2xmldata/esx-in-the-wild-10.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-11.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-12.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-13.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-14.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-15.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-16.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-17.xml |  2 +-
tests/vmx2xmldata/esx-in-the-wild-5.xml  |  2 +-
tests/vmx2xmldata/esx-in-the-wild-6.xml  |  2 +-
tests/vmx2xmldata/esx-in-the-wild-7.xml  |  2 +-
tests/vmx2xmldata/esx-in-the-wild-8.xml  |  2 +-
tests/vmx2xmldata/esx-in-the-wild-9.xml  |  2 +-
21 files changed, 113 insertions(+), 33 deletions(-)
[PATCH v3 0/2] Fix VMWare domain tracking
Posted by Martin Kletzander via Devel an hour ago
v3:
- Remove leftover comment
- Parse both UUIDs and leave the legacy one in <hwuuid>
- Fix the callback for VMX parsing

v2:
- https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/ODGBRHHXD34EBDO3XJVQE5SWXL7VDHQ4/
- ESX driver has an opt-in for the legacy behaviour just in case anynone needs
  that, although hopefully that should not be the case.  The opt-in does not
  exist in the vmware driver or the vmx tests, there the v1 behaviour is kept in
  which vc.uuid is preferred, but uuid.bios is a fallback.

v1:
- https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WEKRADQVZ2CIBNNDRJWXHYQFDXR5MAOD/

Martin Kletzander (2):
  esx: Track VMs by instanceUuid instead of UUID
  NEWS: Add information about VMWare domains having different UUIDs

 NEWS.rst                                 |  9 +++++
 docs/drvesx.rst                          |  9 +++++
 src/esx/esx_driver.c                     | 43 ++++++++++++++++--------
 src/esx/esx_util.c                       | 11 ++++++
 src/esx/esx_util.h                       |  1 +
 src/esx/esx_vi.c                         | 32 +++++++++++++++---
 src/esx/esx_vi.h                         |  3 ++
 src/vmx/vmx.c                            | 12 +++++--
 tests/vmx2xmldata/esx-in-the-wild-10.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-11.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-12.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-13.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-14.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-15.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-16.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-17.xml |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-5.xml  |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-6.xml  |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-7.xml  |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-8.xml  |  2 +-
 tests/vmx2xmldata/esx-in-the-wild-9.xml  |  2 +-
 21 files changed, 113 insertions(+), 33 deletions(-)

-- 
2.54.0
Re: [PATCH v3 0/2] Fix VMWare domain tracking
Posted by Peter Krempa via Devel 59 minutes ago
On Fri, May 15, 2026 at 09:52:00 +0200, Martin Kletzander via Devel wrote:
> v3:
> - Remove leftover comment
> - Parse both UUIDs and leave the legacy one in <hwuuid>
> - Fix the callback for VMX parsing

Note that I'm not familiar with the ESX bits, so I just glanced over
them:

Series:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>