qemu: reduce direct usage of cfg->user

[PATCH 00/16] qemu: reduce direct usage of cfg->user

Cole Robinson via Devel posted 16 patches 1 week, 5 days ago

Download series mbox

Failed in applying to current master (apply log)

src/qemu/qemu_backup.c    |  12 +--
src/qemu/qemu_domain.c    | 150 +++++++++++++++++++-------------------
src/qemu/qemu_domain.h    |  14 ++--
src/qemu/qemu_driver.c    |  25 +++++--
src/qemu/qemu_hotplug.c   |   6 +-
src/qemu/qemu_migration.c |   5 +-
src/qemu/qemu_process.c   |  20 ++---
src/qemu/qemu_saveimage.c |   5 +-
src/qemu/qemu_snapshot.c  |   6 +-
src/qemu/qemu_tpm.c       |   6 +-
10 files changed, 130 insertions(+), 119 deletions(-)

Expand all Fold all

[PATCH 00/16] qemu: reduce direct usage of cfg->user

Posted by Cole Robinson via Devel 1 week, 5 days ago

In the qemu driver, cfg->user and cfg->group are `user` and `group`
from qemu.conf, the default qemu process user and owner for the
security DAC driver. These are driver wide default configuration.
They are used throughout driver code for storage access and launching
sub processes.

However code using cfg->user and cfg->group directly is usually
subtly wrong, because these values can be overridden for individual VMs
with XML like:

<domain>
  <seclabel type='static' model='dac' relabel='yes'>
    <label>+1234:+4567</label>
  </seclabel>
</domain>

Most of the qemu storage code already gets this right (where these
values can also be overridden at the <disk> level). This series fixes
many other users by reusing the existing qemuDomainGetImageIds function
used by the storage code.

https://redhat.atlassian.net/browse/RHEL-119651

Cole Robinson (16):
  qemu: require non-NULL 'cfg' in qemuDomainGetImageIds()
  qemu: tweak qemuDomainGetImageIds() argument handling
  qemu: saveimage: use qemuDomainGetImageIds()
  qemu: domain taint: use qemuDomainGetImageIds()
  qemu: migrate to file: use qemuDomainGetImageIds()
  qemu: core dump: use qemuDomainGetImageIds()
  qemu: storage stat: use qemuDomainGetImageIds()
  qemu: tpm: use qemuDomainGetImageIds()
  qemu: block copy: use qemuDomainGetImageIds()
  qemu: cpu compare: use qemuDomainGetImageIds()
  qemu: nvram: use qemuDomainGetImageIds()
  qemu: simplify qemuProcessPrepareDomainStorage() args
  qemu: nbdkit: use qemuDomainGetImageIds()
  qemu: remove qemuDomainOpenFile() TODO comment
  qemu: don't check virParseOwnershipIds() error
  qemu: use qemuDomainGetImageIds() in qemuDomainOpenFile()

 src/qemu/qemu_backup.c    |  12 +--
 src/qemu/qemu_domain.c    | 150 +++++++++++++++++++-------------------
 src/qemu/qemu_domain.h    |  14 ++--
 src/qemu/qemu_driver.c    |  25 +++++--
 src/qemu/qemu_hotplug.c   |   6 +-
 src/qemu/qemu_migration.c |   5 +-
 src/qemu/qemu_process.c   |  20 ++---
 src/qemu/qemu_saveimage.c |   5 +-
 src/qemu/qemu_snapshot.c  |   6 +-
 src/qemu/qemu_tpm.c       |   6 +-
 10 files changed, 130 insertions(+), 119 deletions(-)

-- 
2.53.0