[PATCH 0/5] qemu: Remove VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE support and fix <readonly>

Peter Krempa via Devel posted 5 patches 13 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1774252743.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                             | 3 +--
src/qemu/qemu_command.c                                  | 5 +----
src/qemu/qemu_validate.c                                 | 8 +-------
tests/domaincapsdata/qemu_10.0.0-q35.x86_64+amdsev.xml   | 1 -
tests/domaincapsdata/qemu_10.0.0-q35.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.0.0-tcg.x86_64+amdsev.xml   | 1 -
tests/domaincapsdata/qemu_10.0.0-tcg.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.0.0-virt.aarch64.xml        | 1 -
tests/domaincapsdata/qemu_10.0.0.aarch64.xml             | 1 -
tests/domaincapsdata/qemu_10.0.0.ppc64.xml               | 1 -
tests/domaincapsdata/qemu_10.0.0.s390x.xml               | 1 -
tests/domaincapsdata/qemu_10.0.0.x86_64+amdsev.xml       | 1 -
tests/domaincapsdata/qemu_10.0.0.x86_64.xml              | 1 -
tests/domaincapsdata/qemu_10.1.0-q35.x86_64+inteltdx.xml | 1 -
tests/domaincapsdata/qemu_10.1.0-q35.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.1.0-tcg.x86_64+inteltdx.xml | 1 -
tests/domaincapsdata/qemu_10.1.0-tcg.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.1.0.s390x.xml               | 1 -
tests/domaincapsdata/qemu_10.1.0.x86_64+inteltdx.xml     | 1 -
tests/domaincapsdata/qemu_10.1.0.x86_64.xml              | 1 -
tests/domaincapsdata/qemu_10.2.0-q35.x86_64+mshv.xml     | 1 -
tests/domaincapsdata/qemu_10.2.0-q35.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.2.0-tcg.x86_64+mshv.xml     | 1 -
tests/domaincapsdata/qemu_10.2.0-tcg.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_10.2.0-virt.aarch64.xml        | 1 -
tests/domaincapsdata/qemu_10.2.0.aarch64.xml             | 1 -
tests/domaincapsdata/qemu_10.2.0.x86_64+mshv.xml         | 1 -
tests/domaincapsdata/qemu_10.2.0.x86_64.xml              | 1 -
tests/domaincapsdata/qemu_11.0.0-q35.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_11.0.0-tcg.x86_64.xml          | 1 -
tests/domaincapsdata/qemu_11.0.0-virt.aarch64.xml        | 1 -
tests/domaincapsdata/qemu_11.0.0.aarch64.xml             | 1 -
tests/domaincapsdata/qemu_11.0.0.x86_64.xml              | 1 -
tests/domaincapsdata/qemu_6.2.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_6.2.0.ppc64.xml                | 1 -
tests/domaincapsdata/qemu_6.2.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.0.0.ppc64.xml                | 1 -
tests/domaincapsdata/qemu_7.0.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.1.0.ppc64.xml                | 1 -
tests/domaincapsdata/qemu_7.1.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_7.2.0-hvf.x86_64+hvf.xml       | 1 -
tests/domaincapsdata/qemu_7.2.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.2.0-tcg.x86_64+hvf.xml       | 1 -
tests/domaincapsdata/qemu_7.2.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_7.2.0.ppc.xml                  | 1 -
tests/domaincapsdata/qemu_7.2.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_8.0.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.0.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.0.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.1.0.s390x.xml                | 1 -
tests/domaincapsdata/qemu_8.1.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_8.2.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.2.0-tcg-virt.loongarch64.xml | 1 -
tests/domaincapsdata/qemu_8.2.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_8.2.0-virt.aarch64.xml         | 1 -
tests/domaincapsdata/qemu_8.2.0-virt.loongarch64.xml     | 1 -
tests/domaincapsdata/qemu_8.2.0.aarch64.xml              | 1 -
tests/domaincapsdata/qemu_8.2.0.armv7l.xml               | 1 -
tests/domaincapsdata/qemu_8.2.0.s390x.xml                | 1 -
tests/domaincapsdata/qemu_8.2.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_9.0.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.0.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.0.0.sparc.xml                | 1 -
tests/domaincapsdata/qemu_9.0.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_9.1.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.1.0-tcg-virt.riscv64.xml     | 1 -
tests/domaincapsdata/qemu_9.1.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.1.0-virt.riscv64.xml         | 1 -
tests/domaincapsdata/qemu_9.1.0.s390x.xml                | 1 -
tests/domaincapsdata/qemu_9.1.0.x86_64.xml               | 1 -
tests/domaincapsdata/qemu_9.2.0-hvf.aarch64+hvf.xml      | 1 -
tests/domaincapsdata/qemu_9.2.0-q35.x86_64+amdsev.xml    | 1 -
tests/domaincapsdata/qemu_9.2.0-q35.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.2.0-tcg.x86_64+amdsev.xml    | 1 -
tests/domaincapsdata/qemu_9.2.0-tcg.x86_64.xml           | 1 -
tests/domaincapsdata/qemu_9.2.0.s390x.xml                | 1 -
tests/domaincapsdata/qemu_9.2.0.x86_64+amdsev.xml        | 1 -
tests/domaincapsdata/qemu_9.2.0.x86_64.xml               | 1 -
tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args         | 4 +---
tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml          | 8 +-------
tests/qemuxmlconfdata/fs9p-ccw.xml                       | 5 -----
tests/qemuxmlconfdata/fs9p.x86_64-latest.args            | 4 ++--
tests/qemuxmlconfdata/fs9p.x86_64-latest.xml             | 9 +++++----
tests/qemuxmlconfdata/fs9p.xml                           | 9 +++++----
91 files changed, 17 insertions(+), 120 deletions(-)
[PATCH 0/5] qemu: Remove VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE support and fix <readonly>
Posted by Peter Krempa via Devel 13 hours ago
VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE isn't supported since qemu-4.0 but we
do declare that it is supported. Remove that.

Also <readonly> converts to ",readonly" which is deprecated and removed
and ",readonly=on" must be used instead.

Peter Krempa (5):
  qemu: validate: Reject configs with VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
  qemu: capabilities: Don't advertise support for
    VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
  qemuBuildFSStr: Drop code for VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
  qemuBuildFSStr: Properly format 'readonly' attribute
  qemuxmlconftest: Add missing test for <readonly> attribute of p9-fs
    devices

 src/qemu/qemu_capabilities.c                             | 3 +--
 src/qemu/qemu_command.c                                  | 5 +----
 src/qemu/qemu_validate.c                                 | 8 +-------
 tests/domaincapsdata/qemu_10.0.0-q35.x86_64+amdsev.xml   | 1 -
 tests/domaincapsdata/qemu_10.0.0-q35.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.0.0-tcg.x86_64+amdsev.xml   | 1 -
 tests/domaincapsdata/qemu_10.0.0-tcg.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.0.0-virt.aarch64.xml        | 1 -
 tests/domaincapsdata/qemu_10.0.0.aarch64.xml             | 1 -
 tests/domaincapsdata/qemu_10.0.0.ppc64.xml               | 1 -
 tests/domaincapsdata/qemu_10.0.0.s390x.xml               | 1 -
 tests/domaincapsdata/qemu_10.0.0.x86_64+amdsev.xml       | 1 -
 tests/domaincapsdata/qemu_10.0.0.x86_64.xml              | 1 -
 tests/domaincapsdata/qemu_10.1.0-q35.x86_64+inteltdx.xml | 1 -
 tests/domaincapsdata/qemu_10.1.0-q35.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.1.0-tcg.x86_64+inteltdx.xml | 1 -
 tests/domaincapsdata/qemu_10.1.0-tcg.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.1.0.s390x.xml               | 1 -
 tests/domaincapsdata/qemu_10.1.0.x86_64+inteltdx.xml     | 1 -
 tests/domaincapsdata/qemu_10.1.0.x86_64.xml              | 1 -
 tests/domaincapsdata/qemu_10.2.0-q35.x86_64+mshv.xml     | 1 -
 tests/domaincapsdata/qemu_10.2.0-q35.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.2.0-tcg.x86_64+mshv.xml     | 1 -
 tests/domaincapsdata/qemu_10.2.0-tcg.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_10.2.0-virt.aarch64.xml        | 1 -
 tests/domaincapsdata/qemu_10.2.0.aarch64.xml             | 1 -
 tests/domaincapsdata/qemu_10.2.0.x86_64+mshv.xml         | 1 -
 tests/domaincapsdata/qemu_10.2.0.x86_64.xml              | 1 -
 tests/domaincapsdata/qemu_11.0.0-q35.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_11.0.0-tcg.x86_64.xml          | 1 -
 tests/domaincapsdata/qemu_11.0.0-virt.aarch64.xml        | 1 -
 tests/domaincapsdata/qemu_11.0.0.aarch64.xml             | 1 -
 tests/domaincapsdata/qemu_11.0.0.x86_64.xml              | 1 -
 tests/domaincapsdata/qemu_6.2.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_6.2.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_6.2.0.ppc64.xml                | 1 -
 tests/domaincapsdata/qemu_6.2.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_7.0.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.0.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.0.0.ppc64.xml                | 1 -
 tests/domaincapsdata/qemu_7.0.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_7.1.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.1.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.1.0.ppc64.xml                | 1 -
 tests/domaincapsdata/qemu_7.1.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_7.2.0-hvf.x86_64+hvf.xml       | 1 -
 tests/domaincapsdata/qemu_7.2.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.2.0-tcg.x86_64+hvf.xml       | 1 -
 tests/domaincapsdata/qemu_7.2.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_7.2.0.ppc.xml                  | 1 -
 tests/domaincapsdata/qemu_7.2.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_8.0.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.0.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.0.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_8.1.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.1.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.1.0.s390x.xml                | 1 -
 tests/domaincapsdata/qemu_8.1.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_8.2.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.2.0-tcg-virt.loongarch64.xml | 1 -
 tests/domaincapsdata/qemu_8.2.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_8.2.0-virt.aarch64.xml         | 1 -
 tests/domaincapsdata/qemu_8.2.0-virt.loongarch64.xml     | 1 -
 tests/domaincapsdata/qemu_8.2.0.aarch64.xml              | 1 -
 tests/domaincapsdata/qemu_8.2.0.armv7l.xml               | 1 -
 tests/domaincapsdata/qemu_8.2.0.s390x.xml                | 1 -
 tests/domaincapsdata/qemu_8.2.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_9.0.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.0.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.0.0.sparc.xml                | 1 -
 tests/domaincapsdata/qemu_9.0.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_9.1.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.1.0-tcg-virt.riscv64.xml     | 1 -
 tests/domaincapsdata/qemu_9.1.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.1.0-virt.riscv64.xml         | 1 -
 tests/domaincapsdata/qemu_9.1.0.s390x.xml                | 1 -
 tests/domaincapsdata/qemu_9.1.0.x86_64.xml               | 1 -
 tests/domaincapsdata/qemu_9.2.0-hvf.aarch64+hvf.xml      | 1 -
 tests/domaincapsdata/qemu_9.2.0-q35.x86_64+amdsev.xml    | 1 -
 tests/domaincapsdata/qemu_9.2.0-q35.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.2.0-tcg.x86_64+amdsev.xml    | 1 -
 tests/domaincapsdata/qemu_9.2.0-tcg.x86_64.xml           | 1 -
 tests/domaincapsdata/qemu_9.2.0.s390x.xml                | 1 -
 tests/domaincapsdata/qemu_9.2.0.x86_64+amdsev.xml        | 1 -
 tests/domaincapsdata/qemu_9.2.0.x86_64.xml               | 1 -
 tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.args         | 4 +---
 tests/qemuxmlconfdata/fs9p-ccw.s390x-latest.xml          | 8 +-------
 tests/qemuxmlconfdata/fs9p-ccw.xml                       | 5 -----
 tests/qemuxmlconfdata/fs9p.x86_64-latest.args            | 4 ++--
 tests/qemuxmlconfdata/fs9p.x86_64-latest.xml             | 9 +++++----
 tests/qemuxmlconfdata/fs9p.xml                           | 9 +++++----
 91 files changed, 17 insertions(+), 120 deletions(-)

-- 
2.53.0
Re: [PATCH 0/5] qemu: Remove VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE support and fix <readonly>
Posted by Michal Prívozník via Devel 11 hours ago
On 3/23/26 09:00, Peter Krempa via Devel wrote:
> VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE isn't supported since qemu-4.0 but we
> do declare that it is supported. Remove that.
> 
> Also <readonly> converts to ",readonly" which is deprecated and removed
> and ",readonly=on" must be used instead.
> 
> Peter Krempa (5):
>   qemu: validate: Reject configs with VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
>   qemu: capabilities: Don't advertise support for
>     VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
>   qemuBuildFSStr: Drop code for VIR_DOMAIN_FS_DRIVER_TYPE_HANDLE
>   qemuBuildFSStr: Properly format 'readonly' attribute
>   qemuxmlconftest: Add missing test for <readonly> attribute of p9-fs
>     devices
> 

>  91 files changed, 17 insertions(+), 120 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal