[v2] hyperv: Implement virDomainInterfaceAddresses()

[PATCH v2 0/4] hyperv: Implement virDomainInterfaceAddresses()

Michal Privoznik via Devel posted 4 patches 2 weeks, 4 days ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1770904246.git.mprivozn@redhat.com

src/datatypes.h                       |   2 +
src/hyperv/hyperv_driver.c            | 226 +++++++++++++++++++++++---
src/hyperv/hyperv_wmi_generator.input |  12 ++
src/libvirt_private.syms              |   1 +
src/util/virsocketaddr.c              |  53 ++++++
src/util/virsocketaddr.h              |   2 +
tests/sockettest.c                    |  33 ++++
7 files changed, 304 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH v2 0/4] hyperv: Implement virDomainInterfaceAddresses()

Posted by Michal Privoznik via Devel 2 weeks, 4 days ago

v2 of:

diff to v1:
- In 2/4 document corner case behavior of virSocketAddrSubnetToPrefix,
- In 2/4 make the test report actual and expected values,
- In 4/4 fix a possible mem leak if hypervDomainInterfaceAddressesParseOne() fails

Michal Prívozník (4):
  datatypes: Declare autofree func for virDomainInterface type
  virsocketaddr: Introduce virSocketAddrSubnetToPrefix()
  hyperv: Move MAC parsing into a separate function
  hyperv: Implement virDomainInterfaceAddresses()

 src/datatypes.h                       |   2 +
 src/hyperv/hyperv_driver.c            | 226 +++++++++++++++++++++++---
 src/hyperv/hyperv_wmi_generator.input |  12 ++
 src/libvirt_private.syms              |   1 +
 src/util/virsocketaddr.c              |  53 ++++++
 src/util/virsocketaddr.h              |   2 +
 tests/sockettest.c                    |  33 ++++
 7 files changed, 304 insertions(+), 25 deletions(-)

-- 
2.52.0

Re: [PATCH v2 0/4] hyperv: Implement virDomainInterfaceAddresses()

Posted by Peter Krempa via Devel 2 weeks, 4 days ago

On Thu, Feb 12, 2026 at 14:52:54 +0100, Michal Privoznik via Devel wrote:
> v2 of:
> 
> diff to v1:
> - In 2/4 document corner case behavior of virSocketAddrSubnetToPrefix,
> - In 2/4 make the test report actual and expected values,
> - In 4/4 fix a possible mem leak if hypervDomainInterfaceAddressesParseOne() fails
> 
> Michal Prívozník (4):
>   datatypes: Declare autofree func for virDomainInterface type
>   virsocketaddr: Introduce virSocketAddrSubnetToPrefix()
>   hyperv: Move MAC parsing into a separate function
>   hyperv: Implement virDomainInterfaceAddresses()
> 
>  src/datatypes.h                       |   2 +
>  src/hyperv/hyperv_driver.c            | 226 +++++++++++++++++++++++---
>  src/hyperv/hyperv_wmi_generator.input |  12 ++
>  src/libvirt_private.syms              |   1 +
>  src/util/virsocketaddr.c              |  53 ++++++
>  src/util/virsocketaddr.h              |   2 +
>  tests/sockettest.c                    |  33 ++++
>  7 files changed, 304 insertions(+), 25 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>