[PATCH 03/20] qemuProcessRefreshDiskProps: Drop code to remove disk source

Peter Krempa via Devel posted 20 patches 3 days, 11 hours ago
[PATCH 03/20] qemuProcessRefreshDiskProps: Drop code to remove disk source
Posted by Peter Krempa via Devel 3 days, 11 hours ago
From: Peter Krempa <pkrempa@redhat.com>

In blockdev mode, the guest OS can't force the drive to become empty
(opening cdrom tray doesn't remove media; floppies can't be ejected from
guest OS), so the check if a drive is empty is dead code at this point.

Remove it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_process.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index fba1dbe844..c130483659 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -9544,9 +9544,6 @@ qemuProcessRefreshDiskProps(virDomainDiskDef *disk,
     qemuDomainDiskPrivate *diskpriv = QEMU_DOMAIN_DISK_PRIVATE(disk);

     if (info->removable) {
-        if (info->empty)
-            virDomainDiskEmptySource(disk);
-
         if (info->tray) {
             if (info->tray_open)
                 disk->tray_status = VIR_DOMAIN_DISK_TRAY_OPEN;
-- 
2.53.0