qemu: migration: Always try to migrate block dirty bitmaps

[PATCH 0/5] qemu: migration: Always try to migrate block dirty bitmaps

Peter Krempa via Devel posted 5 patches 4 days, 10 hours ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1769622307.git.pkrempa@redhat.com

src/qemu/qemu_migration.c                     | 54 ++++++-------------
src/qemu/qemu_monitor.h                       |  4 ++
src/qemu/qemu_monitor_json.c                  | 17 ++++++
tests/qemublocktest.c                         | 35 ++++++------
tests/qemublocktestdata/bitmap/basic.out      |  1 +
tests/qemublocktestdata/bitmap/empty.out      |  1 +
.../bitmap/snapshots-internal.out             |  7 +++
tests/qemublocktestdata/bitmap/snapshots.out  | 10 ++++
tests/qemublocktestdata/bitmap/synthetic.out  |  9 ++++
9 files changed, 86 insertions(+), 52 deletions(-)

Expand all Fold all

[PATCH 0/5] qemu: migration: Always try to migrate block dirty bitmaps

Posted by Peter Krempa via Devel 4 days, 10 hours ago

Try to migrate them always when they are not present in the destination
image. While this has no change if they are present and on shared
filesystem it does allow migrating them when the filesystem is not
shared but we're not migrating storage. This is a special case for qcow2
overlay with data_file feature.

The code uses the existing logic for offering and accepting bitmaps,
just fixed a bug and enables the code for all kinds of migration.

See 5/5 for more in-depth description.

Peter Krempa (5):
  qemublocktest: Iterate all nodenames in 'testQemuDetectBitmaps'
  qemu: monitor: Detect list of bitmaps from 'qcow2' format specific
    data
  qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Fix check for existing
    bitmaps
  qemu: migration: Always offer block dirty bitmaps during migration
  qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Always consider offered
    bitmaps

 src/qemu/qemu_migration.c                     | 54 ++++++-------------
 src/qemu/qemu_monitor.h                       |  4 ++
 src/qemu/qemu_monitor_json.c                  | 17 ++++++
 tests/qemublocktest.c                         | 35 ++++++------
 tests/qemublocktestdata/bitmap/basic.out      |  1 +
 tests/qemublocktestdata/bitmap/empty.out      |  1 +
 .../bitmap/snapshots-internal.out             |  7 +++
 tests/qemublocktestdata/bitmap/snapshots.out  | 10 ++++
 tests/qemublocktestdata/bitmap/synthetic.out  |  9 ++++
 9 files changed, 86 insertions(+), 52 deletions(-)

-- 
2.52.0

Re: [PATCH 0/5] qemu: migration: Always try to migrate block dirty bitmaps

Posted by Ján Tomko via Devel 3 days, 18 hours ago

On a Wednesday in 2026, Peter Krempa via Devel wrote:
>Try to migrate them always when they are not present in the destination
>image. While this has no change if they are present and on shared
>filesystem it does allow migrating them when the filesystem is not
>shared but we're not migrating storage. This is a special case for qcow2
>overlay with data_file feature.
>
>The code uses the existing logic for offering and accepting bitmaps,
>just fixed a bug and enables the code for all kinds of migration.
>
>See 5/5 for more in-depth description.
>
>Peter Krempa (5):
>  qemublocktest: Iterate all nodenames in 'testQemuDetectBitmaps'
>  qemu: monitor: Detect list of bitmaps from 'qcow2' format specific
>    data
>  qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Fix check for existing
>    bitmaps
>  qemu: migration: Always offer block dirty bitmaps during migration
>  qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Always consider offered
>    bitmaps
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano