[PATCH 04/20] networkxml2conftest: Drop routed-network-no-dns test case

Michal Privoznik via Devel posted 20 patches 4 days, 15 hours ago
[PATCH 04/20] networkxml2conftest: Drop routed-network-no-dns test case
Posted by Michal Privoznik via Devel 4 days, 15 hours ago
From: Michal Privoznik <mprivozn@redhat.com>

This test case is spurious. If this was real life scenario then
no dnsmasq would be spawned and yet, the test tries to generate
dnsmasq config for it. Just drop the test case and move on.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tests/networkxml2confdata/routed-network-no-dns.conf | 11 -----------
 tests/networkxml2confdata/routed-network-no-dns.xml  | 10 ----------
 tests/networkxml2conftest.c                          |  1 -
 3 files changed, 22 deletions(-)
 delete mode 100644 tests/networkxml2confdata/routed-network-no-dns.conf
 delete mode 100644 tests/networkxml2confdata/routed-network-no-dns.xml

diff --git a/tests/networkxml2confdata/routed-network-no-dns.conf b/tests/networkxml2confdata/routed-network-no-dns.conf
deleted file mode 100644
index 83cc85ea6b..0000000000
--- a/tests/networkxml2confdata/routed-network-no-dns.conf
+++ /dev/null
@@ -1,11 +0,0 @@
-##WARNING:  THIS IS AN AUTO-GENERATED FILE. CHANGES TO IT ARE LIKELY TO BE
-##OVERWRITTEN AND LOST.  Changes to this configuration should be made using:
-##    virsh net-edit local
-## or other application using the libvirt API.
-##
-## dnsmasq conf file created by libvirt
-strict-order
-port=0
-except-interface=lo
-bind-dynamic
-interface=virbr1
diff --git a/tests/networkxml2confdata/routed-network-no-dns.xml b/tests/networkxml2confdata/routed-network-no-dns.xml
deleted file mode 100644
index 70d041745d..0000000000
--- a/tests/networkxml2confdata/routed-network-no-dns.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-<network>
-  <name>local</name>
-  <uuid>81ff0d90-c91e-6742-64da-4a736edb9a9b</uuid>
-  <bridge name="virbr1"/>
-  <mac address='12:34:56:78:9A:BC'/>
-  <forward mode="route" dev="eth1"/>
-  <dns enable='no'/>
-  <ip address="192.168.122.1" netmask="255.255.255.0">
-  </ip>
-</network>
diff --git a/tests/networkxml2conftest.c b/tests/networkxml2conftest.c
index 70fb3a37b9..aa0adbdd52 100644
--- a/tests/networkxml2conftest.c
+++ b/tests/networkxml2conftest.c
@@ -174,7 +174,6 @@ mymain(void)
     DO_TEST("nat-network-dns-srv-record-minimal", full);
     DO_TEST("nat-network-name-with-quotes", full);
     DO_TEST("routed-network", full);
-    DO_TEST("routed-network-no-dns", full);
     DO_TEST("open-network", full);
     DO_TEST("nat-network", full);
     DO_TEST("nat-network-dns-txt-record", full);
-- 
2.52.0