[v2] libvirt-guests.sh: Declare and assign separately to avoid masking return values

[PATCH v2 0/3] libvirt-guests.sh: Declare and assign separately to avoid masking return values

Michal Privoznik via Devel posted 3 patches 1 week, 6 days ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1768823107.git.mprivozn@redhat.com

build-aux/syntax-check.mk  | 11 +++++++++++
tools/libvirt-guests.sh.in | 12 ++++++++----
2 files changed, 19 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH v2 0/3] libvirt-guests.sh: Declare and assign separately to avoid masking return values

Posted by Michal Privoznik via Devel 1 week, 6 days ago

v2 of:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/RXHDIUTBI534XXCL5MNYUHSUDISZOAFE/

diff to v1:
- perfected the syntax-check rule
- due to this fewer changes to libvirt-guests.sh.in file are necessary

Michal Prívozník (3):
  libvirt-guests.sh: Declare and assign separately to avoid masking
    return values
  libvirt-guest.sh.in: Fix logical error in guest_is_on()
  syntax-check: Introduce sc_prohibit_local_with_subshell rule

 build-aux/syntax-check.mk  | 11 +++++++++++
 tools/libvirt-guests.sh.in | 12 ++++++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

-- 
2.52.0

Re: [PATCH v2 0/3] libvirt-guests.sh: Declare and assign separately to avoid masking return values

Posted by Ján Tomko via Devel 1 week, 6 days ago

On a Monday in 2026, Michal Privoznik via Devel wrote:
>v2 of:
>
>https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/RXHDIUTBI534XXCL5MNYUHSUDISZOAFE/
>
>diff to v1:
>- perfected the syntax-check rule
>- due to this fewer changes to libvirt-guests.sh.in file are necessary
>
>Michal Prívozník (3):
>  libvirt-guests.sh: Declare and assign separately to avoid masking
>    return values
>  libvirt-guest.sh.in: Fix logical error in guest_is_on()
>  syntax-check: Introduce sc_prohibit_local_with_subshell rule
>
> build-aux/syntax-check.mk  | 11 +++++++++++
> tools/libvirt-guests.sh.in | 12 ++++++++----
> 2 files changed, 19 insertions(+), 4 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano