[PATCH 1/4] qemuDomainSetThrottleGroup: Enforce non-zero 'groupname' string length

Peter Krempa via Devel posted 4 patches 1 week, 6 days ago
[PATCH 1/4] qemuDomainSetThrottleGroup: Enforce non-zero 'groupname' string length
Posted by Peter Krempa via Devel 1 week, 6 days ago
From: Peter Krempa <pkrempa@redhat.com>

Having a name of 0 characters makes no sense. Reject it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_driver.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 3f154969b8..bed60d1ca7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -20354,6 +20354,12 @@ qemuDomainSetThrottleGroup(virDomainPtr dom,
     virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
                   VIR_DOMAIN_AFFECT_CONFIG, -1);

+    if (strlen(groupname) == 0) {
+        virReportError(VIR_ERR_INVALID_ARG, "%s",
+                       _("'groupname' parameter string must have non-zero length"));
+        return -1;
+    }
+
     if (qemuDomainValidateBlockIoTune(params, nparams) < 0)
         return -1;

-- 
2.52.0