syntax-check: Introduce sc_prohibit_g_autofree_const rule

[PATCH 0/3] syntax-check: Introduce sc_prohibit_g_autofree_const rule

Michal Privoznik via Devel posted 3 patches 3 weeks, 2 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1767943944.git.mprivozn@redhat.com

build-aux/syntax-check.mk  | 6 ++++++
src/hyperv/hyperv_driver.c | 2 +-
src/network/network_pf.c   | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH 0/3] syntax-check: Introduce sc_prohibit_g_autofree_const rule

Posted by Michal Privoznik via Devel 3 weeks, 2 days ago

Stems out from discussion here:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/HYTV56IUBMBXWJGAUBE4NNHP6AGLHRD6/

Michal Prívozník (3):
  hyperv: Drop const for resourceType in hypervDomainAttachSerial()
  network: Drop const for forwardIf in pfAddNatFirewallRules()
  syntax-check: Introduce sc_prohibit_g_autofree_const rule

 build-aux/syntax-check.mk  | 6 ++++++
 src/hyperv/hyperv_driver.c | 2 +-
 src/network/network_pf.c   | 2 +-
 3 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.52.0

Re: [PATCH 0/3] syntax-check: Introduce sc_prohibit_g_autofree_const rule

Posted by Jiri Denemark via Devel 2 weeks, 5 days ago

On Fri, Jan 09, 2026 at 08:33:49 +0100, Michal Privoznik wrote:
> Stems out from discussion here:
> 
> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/HYTV56IUBMBXWJGAUBE4NNHP6AGLHRD6/
> 
> Michal Prívozník (3):
>   hyperv: Drop const for resourceType in hypervDomainAttachSerial()
>   network: Drop const for forwardIf in pfAddNatFirewallRules()
>   syntax-check: Introduce sc_prohibit_g_autofree_const rule
> 
>  build-aux/syntax-check.mk  | 6 ++++++
>  src/hyperv/hyperv_driver.c | 2 +-
>  src/network/network_pf.c   | 2 +-
>  3 files changed, 8 insertions(+), 2 deletions(-)

The regexp looks a bit strange to me (probably because I haven't seen
all the lines it has to match or ignore), but I guess it work as is and
if it stops working, we can update it later :-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>