[PATCH 00/10] qemu: Snapshot and saveimage related refactors (background snapshot saga part 2)

Peter Krempa via Devel posted 10 patches 1 month, 4 weeks ago
Failed in applying to current master (apply log)
src/qemu/qemu_backup.c    |  2 +-
src/qemu/qemu_domainjob.c |  6 +++---
src/qemu/qemu_domainjob.h |  3 +--
src/qemu/qemu_driver.c    |  4 ++--
src/qemu/qemu_hotplug.c   |  6 ++----
src/qemu/qemu_hotplug.h   |  3 +--
src/qemu/qemu_migration.c | 36 ++++++++++++++++++------------------
src/qemu/qemu_migration.h |  5 ++---
src/qemu/qemu_saveimage.c | 27 ++++++++++++---------------
src/qemu/qemu_saveimage.h |  3 +--
src/qemu/qemu_snapshot.c  | 22 ++++++++++++----------
11 files changed, 55 insertions(+), 62 deletions(-)
[PATCH 00/10] qemu: Snapshot and saveimage related refactors (background snapshot saga part 2)
Posted by Peter Krempa via Devel 1 month, 4 weeks ago
This series fixes up some code (mostly removes unneeded) 'driver'
argument and fixes control flow in some snapshot and save image related
functions.

This series also contains 2 patches necromanced from the original
attempt to add background snapshot from Nikolay.

Nikolay Shirokovskiy (2):
  qemu: snapshot: Don't overwrite 'ret' in
    qemuSnapshotCreateActiveExternal
  qemu: snapshot: Check earlier if memory snapshot is possible

Peter Krempa (8):
  qemuHotplugAttachDBusVMState: Remove 'driver' argument
  qemuMigrationSrcToLegacyFile: Remove 'driver' argument
  qemuDomainEventEmitJobCompleted: Remove 'driver' argument
  qemuMigrationSrcToSparseFile: Remove 'driver' argument
  qemuMigrationSrcToFile: Remove 'driver' argument
  qemuSaveImageCreateFd: Remove 'driver' argument
  qemuSaveImageCreate: Remove 'driver' argument
  virQEMUSaveDataNew: Refactor cleanup

 src/qemu/qemu_backup.c    |  2 +-
 src/qemu/qemu_domainjob.c |  6 +++---
 src/qemu/qemu_domainjob.h |  3 +--
 src/qemu/qemu_driver.c    |  4 ++--
 src/qemu/qemu_hotplug.c   |  6 ++----
 src/qemu/qemu_hotplug.h   |  3 +--
 src/qemu/qemu_migration.c | 36 ++++++++++++++++++------------------
 src/qemu/qemu_migration.h |  5 ++---
 src/qemu/qemu_saveimage.c | 27 ++++++++++++---------------
 src/qemu/qemu_saveimage.h |  3 +--
 src/qemu/qemu_snapshot.c  | 22 ++++++++++++----------
 11 files changed, 55 insertions(+), 62 deletions(-)

-- 
2.52.0
Re: [PATCH 00/10] qemu: Snapshot and saveimage related refactors (background snapshot saga part 2)
Posted by Ján Tomko via Devel 1 month ago
On a Wednesday in 2025, Peter Krempa via Devel wrote:
>This series fixes up some code (mostly removes unneeded) 'driver'
>argument and fixes control flow in some snapshot and save image related
>functions.
>
>This series also contains 2 patches necromanced from the original
>attempt to add background snapshot from Nikolay.
>
>Nikolay Shirokovskiy (2):
>  qemu: snapshot: Don't overwrite 'ret' in
>    qemuSnapshotCreateActiveExternal
>  qemu: snapshot: Check earlier if memory snapshot is possible
>
>Peter Krempa (8):
>  qemuHotplugAttachDBusVMState: Remove 'driver' argument
>  qemuMigrationSrcToLegacyFile: Remove 'driver' argument
>  qemuDomainEventEmitJobCompleted: Remove 'driver' argument
>  qemuMigrationSrcToSparseFile: Remove 'driver' argument
>  qemuMigrationSrcToFile: Remove 'driver' argument
>  qemuSaveImageCreateFd: Remove 'driver' argument
>  qemuSaveImageCreate: Remove 'driver' argument
>  virQEMUSaveDataNew: Refactor cleanup
>
> src/qemu/qemu_backup.c    |  2 +-
> src/qemu/qemu_domainjob.c |  6 +++---
> src/qemu/qemu_domainjob.h |  3 +--
> src/qemu/qemu_driver.c    |  4 ++--
> src/qemu/qemu_hotplug.c   |  6 ++----
> src/qemu/qemu_hotplug.h   |  3 +--
> src/qemu/qemu_migration.c | 36 ++++++++++++++++++------------------
> src/qemu/qemu_migration.h |  5 ++---
> src/qemu/qemu_saveimage.c | 27 ++++++++++++---------------
> src/qemu/qemu_saveimage.h |  3 +--
> src/qemu/qemu_snapshot.c  | 22 ++++++++++++----------
> 11 files changed, 55 insertions(+), 62 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [PATCH 00/10] qemu: Snapshot and saveimage related refactors (background snapshot saga part 2)
Posted by Pavel Hrdina via Devel 1 month ago
On Wed, Dec 10, 2025 at 11:32:21AM +0100, Peter Krempa via Devel wrote:
> This series fixes up some code (mostly removes unneeded) 'driver'
> argument and fixes control flow in some snapshot and save image related
> functions.
> 
> This series also contains 2 patches necromanced from the original
> attempt to add background snapshot from Nikolay.
> 
> Nikolay Shirokovskiy (2):
>   qemu: snapshot: Don't overwrite 'ret' in
>     qemuSnapshotCreateActiveExternal
>   qemu: snapshot: Check earlier if memory snapshot is possible
> 
> Peter Krempa (8):
>   qemuHotplugAttachDBusVMState: Remove 'driver' argument
>   qemuMigrationSrcToLegacyFile: Remove 'driver' argument
>   qemuDomainEventEmitJobCompleted: Remove 'driver' argument
>   qemuMigrationSrcToSparseFile: Remove 'driver' argument
>   qemuMigrationSrcToFile: Remove 'driver' argument
>   qemuSaveImageCreateFd: Remove 'driver' argument
>   qemuSaveImageCreate: Remove 'driver' argument
>   virQEMUSaveDataNew: Refactor cleanup

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Re: [PATCH 00/10] qemu: Snapshot and saveimage related refactors (background snapshot saga part 2)
Posted by Peter Krempa via Devel 1 month ago
On Wed, Dec 10, 2025 at 11:32:21 +0100, Peter Krempa via Devel wrote:
> This series fixes up some code (mostly removes unneeded) 'driver'
> argument and fixes control flow in some snapshot and save image related
> functions.
> 
> This series also contains 2 patches necromanced from the original
> attempt to add background snapshot from Nikolay.
> 
> Nikolay Shirokovskiy (2):
>   qemu: snapshot: Don't overwrite 'ret' in
>     qemuSnapshotCreateActiveExternal
>   qemu: snapshot: Check earlier if memory snapshot is possible
> 
> Peter Krempa (8):
>   qemuHotplugAttachDBusVMState: Remove 'driver' argument
>   qemuMigrationSrcToLegacyFile: Remove 'driver' argument
>   qemuDomainEventEmitJobCompleted: Remove 'driver' argument
>   qemuMigrationSrcToSparseFile: Remove 'driver' argument
>   qemuMigrationSrcToFile: Remove 'driver' argument
>   qemuSaveImageCreateFd: Remove 'driver' argument
>   qemuSaveImageCreate: Remove 'driver' argument
>   virQEMUSaveDataNew: Refactor cleanup

Ping? :)