[PATCH 1/9] qemuMigrationSrcToFile: Don't leak 'qemuFDPass' in cleanup path

Peter Krempa via Devel posted 9 patches 3 days, 3 hours ago
[PATCH 1/9] qemuMigrationSrcToFile: Don't leak 'qemuFDPass' in cleanup path
Posted by Peter Krempa via Devel 3 days, 3 hours ago
From: Peter Krempa <pkrempa@redhat.com>

A temporary 'qemuFDPass' is used when cleaning up after a migration to a
file but it's not freed after use. Declare it as autoptr.

Fixes: c2518f7bc7d
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_migration.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 9059f9aa3a..4f9b649b63 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -7325,11 +7325,13 @@ qemuMigrationSrcToFile(virQEMUDriver *driver, virDomainObj *vm,
     /* Remove fdset passed to qemu and restore max migration bandwidth */
     if (qemuDomainObjIsActive(vm)) {
         if (qemuDomainObjEnterMonitorAsync(vm, asyncJob) == 0) {
-            qemuFDPass *fdPass =
-                qemuFDPassNewFromMonitor("libvirt-outgoing-migrate", priv->mon);
+            g_autoptr(qemuFDPass) fdPass = NULL;
+
+            fdPass = qemuFDPassNewFromMonitor("libvirt-outgoing-migrate", priv->mon);

             if (fdPass)
                 qemuFDPassTransferMonitorRollback(fdPass, priv->mon);
+
             qemuDomainObjExitMonitor(vm);
         }

-- 
2.52.0