*** BLURB HERE ***

Michal Prívozník (9):
  libvirt_esx.syms: Put proper header file name into comment
  esx: Expose esxParseVMXFileName() for tests
  esx: Make esxVI_LookupDatastoreList() mockable
  esx: Make esxVI_LookupDatastoreHostMount() mockable
  esx: Make esxVI_LookupDatastoreByName() mockable
  tests: Introduce vmx2xmlmock
  vmx2xmltest: Drop custom file name parse function
  esx: Allow disk images in subdirectories
  vmx2xmltest: Add a test case for disks in subfolder

 src/esx/esx_driver.c                     |  24 +++--
 src/esx/esx_driverpriv.h                 |  27 ++++++
 src/esx/esx_vi.h                         |   6 +-
 src/libvirt_esx.syms                     |  23 +++++
 tests/meson.build                        |   5 +-
 tests/vmx2xmldata/esx-in-the-wild-17.vmx | 106 +++++++++++++++++++++++
 tests/vmx2xmldata/esx-in-the-wild-17.xml |  46 ++++++++++
 tests/vmx2xmlmock.c                      |  79 +++++++++++++++++
 tests/vmx2xmltest.c                      |  62 +++----------
 9 files changed, 308 insertions(+), 70 deletions(-)
 create mode 100644 src/esx/esx_driverpriv.h
 create mode 100644 tests/vmx2xmldata/esx-in-the-wild-17.vmx
 create mode 100644 tests/vmx2xmldata/esx-in-the-wild-17.xml
 create mode 100644 tests/vmx2xmlmock.c

-- 
2.51.0

On Thu, Nov 20, 2025 at 09:32:45AM +0100, Michal Privoznik via Devel wrote:
>*** BLURB HERE ***
>
>Michal Prívozník (9):
>  libvirt_esx.syms: Put proper header file name into comment
>  esx: Expose esxParseVMXFileName() for tests
>  esx: Make esxVI_LookupDatastoreList() mockable
>  esx: Make esxVI_LookupDatastoreHostMount() mockable
>  esx: Make esxVI_LookupDatastoreByName() mockable
>  tests: Introduce vmx2xmlmock
>  vmx2xmltest: Drop custom file name parse function
>  esx: Allow disk images in subdirectories
>  vmx2xmltest: Add a test case for disks in subfolder
>

And here's a

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

for patches 1-5,7,9.  I'd suggest squashing 3-5 into one, but that's a
nitpick.

FYI, this series seems to be breaking CI

Segv on tests "23) VMware VMX-2-XML cdrom-ide-file-missing-datastore"

On Thu, Nov 20, 2025 at 02:56:24PM +0100, Martin Kletzander via Devel wrote:
> On Thu, Nov 20, 2025 at 09:32:45AM +0100, Michal Privoznik via Devel wrote:
> > *** BLURB HERE ***
> > 
> > Michal Prívozník (9):
> >  libvirt_esx.syms: Put proper header file name into comment
> >  esx: Expose esxParseVMXFileName() for tests
> >  esx: Make esxVI_LookupDatastoreList() mockable
> >  esx: Make esxVI_LookupDatastoreHostMount() mockable
> >  esx: Make esxVI_LookupDatastoreByName() mockable
> >  tests: Introduce vmx2xmlmock
> >  vmx2xmltest: Drop custom file name parse function
> >  esx: Allow disk images in subdirectories
> >  vmx2xmltest: Add a test case for disks in subfolder
> > 
> 
> And here's a
> 
> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
> 
> for patches 1-5,7,9.  I'd suggest squashing 3-5 into one, but that's a
> nitpick.



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|