Remove use of deprecated 'xmlIndentTreeOutput' variable from libxml2

[PATCH 0/2] Remove use of deprecated 'xmlIndentTreeOutput' variable from libxml2

Peter Krempa via Devel posted 2 patches 1 week, 3 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1762791538.git.pkrempa@redhat.com

src/util/virxml.c             | 10 ----------
src/vbox/vbox_snapshot_conf.c |  5 -----
2 files changed, 15 deletions(-)

Expand all Fold all

[PATCH 0/2] Remove use of deprecated 'xmlIndentTreeOutput' variable from libxml2

Posted by Peter Krempa via Devel 1 week, 3 days ago

The default from libxml2 is '1' which we wanted. Thus all use in
separate processes is okay, and for the few exceptions (see 2/2) the
resulting XML is mis-indented but valid for any app which would override
it.

Peter Krempa (2):
  virVBoxSnapshotConfSaveVboxFile: Don't modify deprecated
    'xmlIndentTreeOutput'
  virXMLFormatMetadata: Don't modify deprecated 'xmlIndentTreeOutput'

 src/util/virxml.c             | 10 ----------
 src/vbox/vbox_snapshot_conf.c |  5 -----
 2 files changed, 15 deletions(-)

-- 
2.51.1

Re: [PATCH 0/2] Remove use of deprecated 'xmlIndentTreeOutput' variable from libxml2

Posted by Michal Prívozník via Devel 1 week, 3 days ago

On 11/10/25 17:20, Peter Krempa via Devel wrote:
> The default from libxml2 is '1' which we wanted. Thus all use in
> separate processes is okay, and for the few exceptions (see 2/2) the
> resulting XML is mis-indented but valid for any app which would override
> it.
> 
> Peter Krempa (2):
>   virVBoxSnapshotConfSaveVboxFile: Don't modify deprecated
>     'xmlIndentTreeOutput'
>   virXMLFormatMetadata: Don't modify deprecated 'xmlIndentTreeOutput'
> 
>  src/util/virxml.c             | 10 ----------
>  src/vbox/vbox_snapshot_conf.c |  5 -----
>  2 files changed, 15 deletions(-)
> 

It's a bit unfortunate that libxml2 deprecated an API without offering a
replacement, but since the newest version is getting into distros and
causing us compile-time warnings we have to act.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal