conf: Introduce virtio options for virtio memory models

[PATCH 4/7] qemu: Use virDomainMemoryIsVirtioModel()

Posted by Michal Privoznik via Devel 1 month, 2 weeks ago

From: Michal Privoznik <mprivozn@redhat.com>

Instead of having these big switch()-es that enumerate all memory
models (but act only on virtio models), let's use
virDomainMemoryIsVirtioModel() helper instead.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_domain_address.c | 44 +++++++---------------------------
 1 file changed, 9 insertions(+), 35 deletions(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index 774541ca06..6d5c4785e8 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -293,18 +293,9 @@ qemuDomainPrimeVirtioDeviceAddresses(virDomainDef *def,
     }
 
     for (i = 0; i < def->nmems; i++) {
-        switch (def->mems[i]->model) {
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM:
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
-            if (def->mems[i]->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE)
-                def->mems[i]->info.type = type;
-            break;
-        case VIR_DOMAIN_MEMORY_MODEL_NONE:
-        case VIR_DOMAIN_MEMORY_MODEL_DIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_NVDIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC:
-        case VIR_DOMAIN_MEMORY_MODEL_LAST:
-            break;
+        if (virDomainMemoryIsVirtioModel(def->mems[i]) &&
+            def->mems[i]->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
+            def->mems[i]->info.type = type;
         }
     }
 
@@ -1024,18 +1015,10 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev,
         break;
 
     case VIR_DOMAIN_DEVICE_MEMORY:
-        switch (dev->data.memory->model) {
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM:
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
+        if (virDomainMemoryIsVirtioModel(dev->data.memory))
             return virtioFlags;
 
-        case VIR_DOMAIN_MEMORY_MODEL_NONE:
-        case VIR_DOMAIN_MEMORY_MODEL_DIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_NVDIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC:
-        case VIR_DOMAIN_MEMORY_MODEL_LAST:
-            return 0;
-        }
+        return 0;
         break;
 
     case VIR_DOMAIN_DEVICE_CRYPTO:
@@ -2444,19 +2427,10 @@ qemuDomainAssignDevicePCISlots(virDomainDef *def,
     for (i = 0; i < def->nmems; i++) {
         virDomainMemoryDef *mem = def->mems[i];
 
-        switch (mem->model) {
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_PMEM:
-        case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
-            if (virDeviceInfoPCIAddressIsWanted(&mem->info) &&
-                qemuDomainPCIAddressReserveNextAddr(addrs, &mem->info) < 0)
-                return -1;
-            break;
-        case VIR_DOMAIN_MEMORY_MODEL_NONE:
-        case VIR_DOMAIN_MEMORY_MODEL_DIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_NVDIMM:
-        case VIR_DOMAIN_MEMORY_MODEL_SGX_EPC:
-        case VIR_DOMAIN_MEMORY_MODEL_LAST:
-            break;
+        if (virDomainMemoryIsVirtioModel(mem) &&
+            virDeviceInfoPCIAddressIsWanted(&mem->info) &&
+            qemuDomainPCIAddressReserveNextAddr(addrs, &mem->info) < 0) {
+            return -1;
         }
     }
 
-- 
2.51.0

Re: [PATCH 4/7] qemu: Use virDomainMemoryIsVirtioModel()

Posted by Jiri Denemark via Devel 1 month, 2 weeks ago

On Wed, Oct 29, 2025 at 08:53:04 +0100, Michal Privoznik wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> Instead of having these big switch()-es that enumerate all memory
> models (but act only on virtio models), let's use
> virDomainMemoryIsVirtioModel() helper instead.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/qemu/qemu_domain_address.c | 44 +++++++---------------------------
>  1 file changed, 9 insertions(+), 35 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>