[PATCH 1/3] virNetDevVlanParse: Don't clear data on failure

Peter Krempa via Devel posted 3 patches 1 week ago
[PATCH 1/3] virNetDevVlanParse: Don't clear data on failure
Posted by Peter Krempa via Devel 1 week ago
From: Peter Krempa <pkrempa@redhat.com>

Clearing the data on failure is pointless as it's still cleared when
other parts of the parser fail.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/conf/netdev_vlan_conf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c
index 1ac66aec54..b98c4d92cf 100644
--- a/src/conf/netdev_vlan_conf.c
+++ b/src/conf/netdev_vlan_conf.c
@@ -122,8 +122,6 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def)
  cleanup:
     VIR_FREE(tagNodes);
     VIR_FREE(trunk);
-    if (ret < 0)
-        virNetDevVlanClear(def);
     return ret;
 }

-- 
2.51.0