ch: Disk attach/detach fixes

[PATCH 0/4] ch: Disk attach/detach fixes

Michal Privoznik via Devel posted 4 patches 3 weeks, 3 days ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1757491293.git.mprivozn@redhat.com

src/ch/ch_hotplug.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)

Expand all Fold all

[PATCH 0/4] ch: Disk attach/detach fixes

Posted by Michal Privoznik via Devel 3 weeks, 3 days ago

While reviewing Stefan patches [1] I've changed some of them before
merging and oopsie, I've introduced a bug (patch 1/4) but fortunately
forgot to remove the code I intended to move so it actually works :-D.


1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HAZRW5NYFJFBGKHLQ5RZL6UYUZGTTHJ3/

Michal Prívozník (4):
  ch: Actually remove device in chDomainDetachDeviceLive()
  ch: Drop deadcode from chDomainDetachDeviceLive()
  ch: Drop useless variable in chDomainFindDisk()
  ch: Avoid memleak on disk detach in chDomainRemoveDevice()

 src/ch/ch_hotplug.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

-- 
2.49.1

Re: [PATCH 0/4] ch: Disk attach/detach fixes

Posted by Ján Tomko via Devel 3 weeks, 3 days ago

On a Wednesday in 2025, Michal Privoznik via Devel wrote:
>While reviewing Stefan patches [1] I've changed some of them before
>merging and oopsie, I've introduced a bug (patch 1/4) but fortunately
>forgot to remove the code I intended to move so it actually works :-D.
>
>
>1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HAZRW5NYFJFBGKHLQ5RZL6UYUZGTTHJ3/
>
>Michal Prívozník (4):
>  ch: Actually remove device in chDomainDetachDeviceLive()
>  ch: Drop deadcode from chDomainDetachDeviceLive()
>  ch: Drop useless variable in chDomainFindDisk()
>  ch: Avoid memleak on disk detach in chDomainRemoveDevice()
>
> src/ch/ch_hotplug.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano