[libvirt PATCH 6/8] tests: qemuxmlconf: virtiofs: remove locking from the readonly test case

Ján Tomko via Devel posted 8 patches 3 weeks, 4 days ago
[libvirt PATCH 6/8] tests: qemuxmlconf: virtiofs: remove locking from the readonly test case
Posted by Ján Tomko via Devel 3 weeks, 4 days ago
From: Ján Tomko <jtomko@redhat.com>

The combination of locking + readonly is bogus, because there has never
been a virtiofsd release that supported both.

Locking was a feature of the C-based virtiofsd that was living in the
QEMU tree until v8.0.0 and the readonly feature was only introduced
in the Rust version of virtiofsd.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 tests/qemuxmlconfdata/vhost-user-fs-readonly.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml b/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
index c9c1e5c3d2..89a6616eec 100644
--- a/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
+++ b/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
@@ -30,7 +30,6 @@
       <driver type='virtiofs' queue='1024'/>
       <binary path='/usr/libexec/virtiofsd' xattr='on'>
         <cache mode='always'/>
-        <lock posix='off' flock='off'/>
       </binary>
       <source dir='/path'/>
       <target dir='mount_tag'/>
-- 
2.50.1

Re: [libvirt PATCH 6/8] tests: qemuxmlconf: virtiofs: remove locking from the readonly test case
Posted by Laine Stump via Devel 2 weeks, 1 day ago
On 9/9/25 8:05 AM, Ján Tomko via Devel wrote:
> From: Ján Tomko <jtomko@redhat.com>
> 
> The combination of locking + readonly is bogus, because there has never
> been a virtiofsd release that supported both.
> 
> Locking was a feature of the C-based virtiofsd that was living in the
> QEMU tree until v8.0.0 and the readonly feature was only introduced
> in the Rust version of virtiofsd.

I'ma take your word for this one dawg. (Writing in a communication style 
that doesn't fit your own personality is apparently the new "in" thing...)

> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>   tests/qemuxmlconfdata/vhost-user-fs-readonly.xml | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml b/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
> index c9c1e5c3d2..89a6616eec 100644
> --- a/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
> +++ b/tests/qemuxmlconfdata/vhost-user-fs-readonly.xml
> @@ -30,7 +30,6 @@
>         <driver type='virtiofs' queue='1024'/>
>         <binary path='/usr/libexec/virtiofsd' xattr='on'>
>           <cache mode='always'/>
> -        <lock posix='off' flock='off'/>
>         </binary>
>         <source dir='/path'/>
>         <target dir='mount_tag'/>