[PATCH 3/5] qemu: domain: Remove unused qemuDomainGetVcpuHalted

Peter Krempa via Devel posted 5 patches 1 month, 1 week ago
[PATCH 3/5] qemu: domain: Remove unused qemuDomainGetVcpuHalted
Posted by Peter Krempa via Devel 1 month, 1 week ago
From: Peter Krempa <pkrempa@redhat.com>

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/qemu/qemu_domain.c | 15 ---------------
 src/qemu/qemu_domain.h |  1 -
 2 files changed, 16 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index a2c7c88a7e..e45757ccd5 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -8603,21 +8603,6 @@ qemuDomainRefreshVcpuInfo(virDomainObj *vm,
     return ret;
 }

-/**
- * qemuDomainGetVcpuHalted:
- * @vm: domain object
- * @vcpu: cpu id
- *
- * Returns the vCPU halted state.
-  */
-bool
-qemuDomainGetVcpuHalted(virDomainObj *vm,
-                        unsigned int vcpuid)
-{
-    virDomainVcpuDef *vcpu = virDomainDefGetVcpu(vm->def, vcpuid);
-    return QEMU_DOMAIN_VCPU_PRIVATE(vcpu)->halted;
-}
-
 /**
  * qemuDomainRefreshVcpuHalted:
  * @driver: qemu driver data
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 1afd932764..ffe5bee1bf 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -870,7 +870,6 @@ int qemuDomainValidateVcpuInfo(virDomainObj *vm);
 int qemuDomainRefreshVcpuInfo(virDomainObj *vm,
                               int asyncJob,
                               bool state);
-bool qemuDomainGetVcpuHalted(virDomainObj *vm, unsigned int vcpu);
 int qemuDomainRefreshVcpuHalted(virDomainObj *vm,
                                 int asyncJob);

-- 
2.50.1
Re: [PATCH 3/5] qemu: domain: Remove unused qemuDomainGetVcpuHalted
Posted by Ján Tomko via Devel 1 month ago
On a Thursday in 2025, Peter Krempa via Devel wrote:
>From: Peter Krempa <pkrempa@redhat.com>
>
>Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>---
> src/qemu/qemu_domain.c | 15 ---------------
> src/qemu/qemu_domain.h |  1 -
> 2 files changed, 16 deletions(-)
>

Unused since:
commit 2222548b1e55257dc8806abdbefa71a87b22dea1

>diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
>index a2c7c88a7e..e45757ccd5 100644
>--- a/src/qemu/qemu_domain.c
>+++ b/src/qemu/qemu_domain.c
>@@ -8603,21 +8603,6 @@ qemuDomainRefreshVcpuInfo(virDomainObj *vm,
>     return ret;
> }
>
>-/**
>- * qemuDomainGetVcpuHalted:
>- * @vm: domain object
>- * @vcpu: cpu id
>- *
>- * Returns the vCPU halted state.
>-  */
>-bool
>-qemuDomainGetVcpuHalted(virDomainObj *vm,
>-                        unsigned int vcpuid)
>-{
>-    virDomainVcpuDef *vcpu = virDomainDefGetVcpu(vm->def, vcpuid);
>-    return QEMU_DOMAIN_VCPU_PRIVATE(vcpu)->halted;
>-}
>-
> /**
>  * qemuDomainRefreshVcpuHalted:
>  * @driver: qemu driver data
>diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
>index 1afd932764..ffe5bee1bf 100644
>--- a/src/qemu/qemu_domain.h
>+++ b/src/qemu/qemu_domain.h
>@@ -870,7 +870,6 @@ int qemuDomainValidateVcpuInfo(virDomainObj *vm);
> int qemuDomainRefreshVcpuInfo(virDomainObj *vm,
>                               int asyncJob,
>                               bool state);
>-bool qemuDomainGetVcpuHalted(virDomainObj *vm, unsigned int vcpu);
> int qemuDomainRefreshVcpuHalted(virDomainObj *vm,
>                                 int asyncJob);
>
>-- 
>2.50.1
>