[PATCH 0/3] sysinfotest: rename output XMLs with .xml suffix and introduce schema testing

Peter Krempa via Devel posted 3 patches 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1751983969.git.pkrempa@redhat.com
src/conf/schemas/domaincommon.rng             | 126 +----------
src/conf/schemas/sysinfo.rng                  |  34 +++
src/conf/schemas/sysinfocommon.rng            | 204 ++++++++++++++++++
...nfo.expect => aarch64-gigabytesysinfo.xml} |   0
...o.expect => aarch64-hpe-apollosysinfo.xml} |   0
...nfo.expect => aarch64-moonshotsysinfo.xml} |   0
...rch64sysinfo.expect => aarch64sysinfo.xml} |   0
...rpi2sysinfo.expect => arm-rpi2sysinfo.xml} |   0
.../{armsysinfo.expect => armsysinfo.xml}     |   0
.../{ppcsysinfo.expect => ppcsysinfo.xml}     |   0
...reqsysinfo.expect => s390-freqsysinfo.xml} |   0
.../{s390sysinfo.expect => s390sysinfo.xml}   |   0
.../{x86sysinfo.expect => x86sysinfo.xml}     |   0
tests/sysinfotest.c                           |   2 +-
tests/virschematest.c                         |   5 +
15 files changed, 251 insertions(+), 120 deletions(-)
create mode 100644 src/conf/schemas/sysinfo.rng
create mode 100644 src/conf/schemas/sysinfocommon.rng
rename tests/sysinfodata/{aarch64-gigabytesysinfo.expect => aarch64-gigabytesysinfo.xml} (100%)
rename tests/sysinfodata/{aarch64-hpe-apollosysinfo.expect => aarch64-hpe-apollosysinfo.xml} (100%)
rename tests/sysinfodata/{aarch64-moonshotsysinfo.expect => aarch64-moonshotsysinfo.xml} (100%)
rename tests/sysinfodata/{aarch64sysinfo.expect => aarch64sysinfo.xml} (100%)
rename tests/sysinfodata/{arm-rpi2sysinfo.expect => arm-rpi2sysinfo.xml} (100%)
rename tests/sysinfodata/{armsysinfo.expect => armsysinfo.xml} (100%)
rename tests/sysinfodata/{ppcsysinfo.expect => ppcsysinfo.xml} (100%)
rename tests/sysinfodata/{s390-freqsysinfo.expect => s390-freqsysinfo.xml} (100%)
rename tests/sysinfodata/{s390sysinfo.expect => s390sysinfo.xml} (100%)
rename tests/sysinfodata/{x86sysinfo.expect => x86sysinfo.xml} (100%)
[PATCH 0/3] sysinfotest: rename output XMLs with .xml suffix and introduce schema testing
Posted by Peter Krempa via Devel 5 months, 1 week ago
As noticed in:

 https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues/10#note_2608097257

This series:
 - renames the output files with .xml suffix
 - refactors the schema for the domain <sysinfo> to be reusable
 - introduces schema to validate the host sysinfo document and tests the
   output files in virschematest

Peter Krempa (3):
  sysinfotest: Use '.xml' suffix for output files
  conf: schemas: Split out common parts of 'sysinfo' schema
  schema: Schema validate host '<sysinfo>' XML test documents

 src/conf/schemas/domaincommon.rng             | 126 +----------
 src/conf/schemas/sysinfo.rng                  |  34 +++
 src/conf/schemas/sysinfocommon.rng            | 204 ++++++++++++++++++
 ...nfo.expect => aarch64-gigabytesysinfo.xml} |   0
 ...o.expect => aarch64-hpe-apollosysinfo.xml} |   0
 ...nfo.expect => aarch64-moonshotsysinfo.xml} |   0
 ...rch64sysinfo.expect => aarch64sysinfo.xml} |   0
 ...rpi2sysinfo.expect => arm-rpi2sysinfo.xml} |   0
 .../{armsysinfo.expect => armsysinfo.xml}     |   0
 .../{ppcsysinfo.expect => ppcsysinfo.xml}     |   0
 ...reqsysinfo.expect => s390-freqsysinfo.xml} |   0
 .../{s390sysinfo.expect => s390sysinfo.xml}   |   0
 .../{x86sysinfo.expect => x86sysinfo.xml}     |   0
 tests/sysinfotest.c                           |   2 +-
 tests/virschematest.c                         |   5 +
 15 files changed, 251 insertions(+), 120 deletions(-)
 create mode 100644 src/conf/schemas/sysinfo.rng
 create mode 100644 src/conf/schemas/sysinfocommon.rng
 rename tests/sysinfodata/{aarch64-gigabytesysinfo.expect => aarch64-gigabytesysinfo.xml} (100%)
 rename tests/sysinfodata/{aarch64-hpe-apollosysinfo.expect => aarch64-hpe-apollosysinfo.xml} (100%)
 rename tests/sysinfodata/{aarch64-moonshotsysinfo.expect => aarch64-moonshotsysinfo.xml} (100%)
 rename tests/sysinfodata/{aarch64sysinfo.expect => aarch64sysinfo.xml} (100%)
 rename tests/sysinfodata/{arm-rpi2sysinfo.expect => arm-rpi2sysinfo.xml} (100%)
 rename tests/sysinfodata/{armsysinfo.expect => armsysinfo.xml} (100%)
 rename tests/sysinfodata/{ppcsysinfo.expect => ppcsysinfo.xml} (100%)
 rename tests/sysinfodata/{s390-freqsysinfo.expect => s390-freqsysinfo.xml} (100%)
 rename tests/sysinfodata/{s390sysinfo.expect => s390sysinfo.xml} (100%)
 rename tests/sysinfodata/{x86sysinfo.expect => x86sysinfo.xml} (100%)

-- 
2.50.0
Re: [PATCH 0/3] sysinfotest: rename output XMLs with .xml suffix and introduce schema testing
Posted by Ján Tomko via Devel 5 months ago
On a Tuesday in 2025, Peter Krempa via Devel wrote:
>As noticed in:
>
> https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues/10#note_2608097257
>
>This series:
> - renames the output files with .xml suffix
> - refactors the schema for the domain <sysinfo> to be reusable
> - introduces schema to validate the host sysinfo document and tests the
>   output files in virschematest
>
>Peter Krempa (3):
>  sysinfotest: Use '.xml' suffix for output files
>  conf: schemas: Split out common parts of 'sysinfo' schema
>  schema: Schema validate host '<sysinfo>' XML test documents
>
> src/conf/schemas/domaincommon.rng             | 126 +----------
> src/conf/schemas/sysinfo.rng                  |  34 +++
> src/conf/schemas/sysinfocommon.rng            | 204 ++++++++++++++++++
> ...nfo.expect => aarch64-gigabytesysinfo.xml} |   0
> ...o.expect => aarch64-hpe-apollosysinfo.xml} |   0
> ...nfo.expect => aarch64-moonshotsysinfo.xml} |   0
> ...rch64sysinfo.expect => aarch64sysinfo.xml} |   0
> ...rpi2sysinfo.expect => arm-rpi2sysinfo.xml} |   0
> .../{armsysinfo.expect => armsysinfo.xml}     |   0
> .../{ppcsysinfo.expect => ppcsysinfo.xml}     |   0
> ...reqsysinfo.expect => s390-freqsysinfo.xml} |   0
> .../{s390sysinfo.expect => s390sysinfo.xml}   |   0
> .../{x86sysinfo.expect => x86sysinfo.xml}     |   0
> tests/sysinfotest.c                           |   2 +-
> tests/virschematest.c                         |   5 +
> 15 files changed, 251 insertions(+), 120 deletions(-)
> create mode 100644 src/conf/schemas/sysinfo.rng
> create mode 100644 src/conf/schemas/sysinfocommon.rng
> rename tests/sysinfodata/{aarch64-gigabytesysinfo.expect => aarch64-gigabytesysinfo.xml} (100%)
> rename tests/sysinfodata/{aarch64-hpe-apollosysinfo.expect => aarch64-hpe-apollosysinfo.xml} (100%)
> rename tests/sysinfodata/{aarch64-moonshotsysinfo.expect => aarch64-moonshotsysinfo.xml} (100%)
> rename tests/sysinfodata/{aarch64sysinfo.expect => aarch64sysinfo.xml} (100%)
> rename tests/sysinfodata/{arm-rpi2sysinfo.expect => arm-rpi2sysinfo.xml} (100%)
> rename tests/sysinfodata/{armsysinfo.expect => armsysinfo.xml} (100%)
> rename tests/sysinfodata/{ppcsysinfo.expect => ppcsysinfo.xml} (100%)
> rename tests/sysinfodata/{s390-freqsysinfo.expect => s390-freqsysinfo.xml} (100%)
> rename tests/sysinfodata/{s390sysinfo.expect => s390sysinfo.xml} (100%)
> rename tests/sysinfodata/{x86sysinfo.expect => x86sysinfo.xml} (100%)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano