qemu: use 'usb-bot' device to properly emulate USB cdroms

[PATCH v2 01/13] qemuhotplugtest: Use VIR_DOMAIN_DEF_PARSE_ABI_UPDATE for virDomainDeviceDefParse

Posted by Peter Krempa via Devel 5 months, 3 weeks ago

From: Peter Krempa <pkrempa@redhat.com>

The qemu hotplug code parses the device with ABI updates enabled so
qemuhotplugtest ought to do the same.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/qemuhotplugtest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c
index d2a1f5acf1..fdb5093549 100644
--- a/tests/qemuhotplugtest.c
+++ b/tests/qemuhotplugtest.c
@@ -152,7 +152,7 @@ testQemuHotplug(const void *data)
     const char *const *tmp;
     bool fail = test->fail;
     bool keep = test->keep;
-    unsigned int device_parse_flags = 0;
+    unsigned int device_parse_flags = VIR_DOMAIN_DEF_PARSE_ABI_UPDATE;
     virDomainObj *vm = NULL;
     g_autoptr(virDomainDeviceDef) dev = NULL;
     g_autoptr(qemuMonitorTest) test_mon = NULL;
@@ -191,7 +191,7 @@ testQemuHotplug(const void *data)
     }

     if (test->action == ATTACH)
-        device_parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE;
+        device_parse_flags |= VIR_DOMAIN_DEF_PARSE_INACTIVE;

     if (!(dev = virDomainDeviceDefParse(device_xml, vm->def,
                                         driver.xmlopt, NULL,
-- 
2.49.0

Re: [PATCH v2 01/13] qemuhotplugtest: Use VIR_DOMAIN_DEF_PARSE_ABI_UPDATE for virDomainDeviceDefParse

Posted by Jiri Denemark via Devel 5 months, 3 weeks ago

On Mon, Jun 23, 2025 at 21:59:06 +0200, Peter Krempa wrote:
> From: Peter Krempa <pkrempa@redhat.com>
> 
> The qemu hotplug code parses the device with ABI updates enabled so
> qemuhotplugtest ought to do the same.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  tests/qemuhotplugtest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>