Various fixes and cleanups

[PATCH 0/6] Various fixes and cleanups

Posted by Peter Krempa via Devel 2 months, 3 weeks ago

A collection of random one-off fixes for issues where the root cause was
analyzed by the reporter and cleanups that I've recently accumulated.

Peter Krempa (6):
  storage_file_probe: Use named initializer for 'struct FileTypeInfo'
  virQEMUCapsFindBinary: Refactor local variables
  virshPrintJobProgress: Don't rewrite migration status line on
    non-terminals
  storage: parthelper: Use if/else instead of ternary operator
  storage: disk: Properly handle partition numbers separated by 'p'
  tlscert: Don't force 'keyEncipherment' for ECDSA and ECDH

 src/qemu/qemu_capabilities.c          |   9 +-
 src/rpc/virnettlscert.c               |  33 +++--
 src/storage/parthelper.c              |   7 +-
 src/storage/storage_backend_disk.c    |   9 +-
 src/storage_file/storage_file_probe.c | 174 ++++++++++++++++++--------
 tools/virsh-domain.c                  |  13 +-
 6 files changed, 165 insertions(+), 80 deletions(-)

-- 
2.49.0

Re: [PATCH 0/6] Various fixes and cleanups

Posted by Michal Prívozník via Devel 2 months, 3 weeks ago

On 6/17/25 15:43, Peter Krempa via Devel wrote:
> A collection of random one-off fixes for issues where the root cause was
> analyzed by the reporter and cleanups that I've recently accumulated.
> 
> Peter Krempa (6):
>   storage_file_probe: Use named initializer for 'struct FileTypeInfo'
>   virQEMUCapsFindBinary: Refactor local variables
>   virshPrintJobProgress: Don't rewrite migration status line on
>     non-terminals
>   storage: parthelper: Use if/else instead of ternary operator
>   storage: disk: Properly handle partition numbers separated by 'p'
>   tlscert: Don't force 'keyEncipherment' for ECDSA and ECDH
> 
>  src/qemu/qemu_capabilities.c          |   9 +-
>  src/rpc/virnettlscert.c               |  33 +++--
>  src/storage/parthelper.c              |   7 +-
>  src/storage/storage_backend_disk.c    |   9 +-
>  src/storage_file/storage_file_probe.c | 174 ++++++++++++++++++--------
>  tools/virsh-domain.c                  |  13 +-
>  6 files changed, 165 insertions(+), 80 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/6] Various fixes and cleanups

Posted by Ján Tomko via Devel 2 months, 3 weeks ago

On a Tuesday in 2025, Peter Krempa via Devel wrote:
>A collection of random one-off fixes for issues where the root cause was
>analyzed by the reporter and cleanups that I've recently accumulated.
>
>Peter Krempa (6):
>  storage_file_probe: Use named initializer for 'struct FileTypeInfo'
>  virQEMUCapsFindBinary: Refactor local variables
>  virshPrintJobProgress: Don't rewrite migration status line on
>    non-terminals
>  storage: parthelper: Use if/else instead of ternary operator
>  storage: disk: Properly handle partition numbers separated by 'p'
>  tlscert: Don't force 'keyEncipherment' for ECDSA and ECDH
>
> src/qemu/qemu_capabilities.c          |   9 +-
> src/rpc/virnettlscert.c               |  33 +++--
> src/storage/parthelper.c              |   7 +-
> src/storage/storage_backend_disk.c    |   9 +-
> src/storage_file/storage_file_probe.c | 174 ++++++++++++++++++--------
> tools/virsh-domain.c                  |  13 +-
> 6 files changed, 165 insertions(+), 80 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano