[PATCH 00/15] virt-aa-helper: Misc improvements

Michal Privoznik via Devel posted 15 patches 2 months, 4 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1749732372.git.mprivozn@redhat.com
src/logging/log_cleaner.c     |   2 +-
src/security/virt-aa-helper.c | 474 +++++++++++++++++-----------------
tests/nssmock.c               |   4 +
tests/qemusecuritymock.c      |   4 +
tests/vircgroupmock.c         |   4 +
tests/virfilewrapper.c        |   4 +
tests/virpcimock.c            |  41 ++-
tests/virt-aa-helper-test     |  77 +++---
tests/virtestmock.c           |   4 +
tests/virusbmock.c            |   4 +
10 files changed, 353 insertions(+), 265 deletions(-)
[PATCH 00/15] virt-aa-helper: Misc improvements
Posted by Michal Privoznik via Devel 2 months, 4 weeks ago
Inspired by a patchset against virt-aa-helper that I reviewed recently:

https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QQXMAK56H2CXCIZPALG5BHDNTKT3OQKZ/

Green pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1866451277

Michal Prívozník (15):
  log_cleaner: Use virFileCanonicalizePath()
  virt-aa-helper: Use virFileCanonicalizePath()
  virpcimock: Automatically invent fakerootdir, if not provided
  virpcimock: Strip fakerootdir prefix in virFileCanonicalizePath()
  tests: Fix mocking of open()
  virt-aa-helper-test: Print errors to stderr
  virt-aa-helper-test: Silence ls
  virt-aa-helper-test: Test hostdevs unconditionally
  virt-aa-helper: Rework USB hostdev handling
  virt-aa-helper: Simplify paths collection
  virt-aa-helper: Decrease scope of @mem_path in get_files()
  virt-aa-helper: Use automatic memory freeing
  virt-aa-helper: Check retval of vah_add_file()
  virt-aa-helper: Drop cleanup label from get_files()
  virt-aa-helper-test: Switch to getopts

 src/logging/log_cleaner.c     |   2 +-
 src/security/virt-aa-helper.c | 474 +++++++++++++++++-----------------
 tests/nssmock.c               |   4 +
 tests/qemusecuritymock.c      |   4 +
 tests/vircgroupmock.c         |   4 +
 tests/virfilewrapper.c        |   4 +
 tests/virpcimock.c            |  41 ++-
 tests/virt-aa-helper-test     |  77 +++---
 tests/virtestmock.c           |   4 +
 tests/virusbmock.c            |   4 +
 10 files changed, 353 insertions(+), 265 deletions(-)

-- 
2.49.0
Re: [PATCH 00/15] virt-aa-helper: Misc improvements
Posted by Ján Tomko via Devel 2 months, 1 week ago
On a Thursday in 2025, Michal Privoznik via Devel wrote:
>Inspired by a patchset against virt-aa-helper that I reviewed recently:
>
>https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QQXMAK56H2CXCIZPALG5BHDNTKT3OQKZ/
>
>Green pipeline:
>
>https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1866451277
>
>Michal Prívozník (15):
>  log_cleaner: Use virFileCanonicalizePath()
>  virt-aa-helper: Use virFileCanonicalizePath()
>  virpcimock: Automatically invent fakerootdir, if not provided
>  virpcimock: Strip fakerootdir prefix in virFileCanonicalizePath()
>  tests: Fix mocking of open()
>  virt-aa-helper-test: Print errors to stderr
>  virt-aa-helper-test: Silence ls
>  virt-aa-helper-test: Test hostdevs unconditionally
>  virt-aa-helper: Rework USB hostdev handling
>  virt-aa-helper: Simplify paths collection
>  virt-aa-helper: Decrease scope of @mem_path in get_files()
>  virt-aa-helper: Use automatic memory freeing
>  virt-aa-helper: Check retval of vah_add_file()
>  virt-aa-helper: Drop cleanup label from get_files()
>  virt-aa-helper-test: Switch to getopts
>
> src/logging/log_cleaner.c     |   2 +-
> src/security/virt-aa-helper.c | 474 +++++++++++++++++-----------------
> tests/nssmock.c               |   4 +
> tests/qemusecuritymock.c      |   4 +
> tests/vircgroupmock.c         |   4 +
> tests/virfilewrapper.c        |   4 +
> tests/virpcimock.c            |  41 ++-
> tests/virt-aa-helper-test     |  77 +++---
> tests/virtestmock.c           |   4 +
> tests/virusbmock.c            |   4 +
> 10 files changed, 353 insertions(+), 265 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano
Re: [PATCH 00/15] virt-aa-helper: Misc improvements
Posted by Michal Prívozník via Devel 2 months, 1 week ago
On 7/2/25 12:12, Ján Tomko wrote:
> On a Thursday in 2025, Michal Privoznik via Devel wrote:
>> Inspired by a patchset against virt-aa-helper that I reviewed recently:
>>
>> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/
>> thread/QQXMAK56H2CXCIZPALG5BHDNTKT3OQKZ/
>>
>> Green pipeline:
>>
>> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1866451277
>>
>> Michal Prívozník (15):
>>  log_cleaner: Use virFileCanonicalizePath()
>>  virt-aa-helper: Use virFileCanonicalizePath()
>>  virpcimock: Automatically invent fakerootdir, if not provided
>>  virpcimock: Strip fakerootdir prefix in virFileCanonicalizePath()
>>  tests: Fix mocking of open()
>>  virt-aa-helper-test: Print errors to stderr
>>  virt-aa-helper-test: Silence ls
>>  virt-aa-helper-test: Test hostdevs unconditionally
>>  virt-aa-helper: Rework USB hostdev handling
>>  virt-aa-helper: Simplify paths collection
>>  virt-aa-helper: Decrease scope of @mem_path in get_files()
>>  virt-aa-helper: Use automatic memory freeing
>>  virt-aa-helper: Check retval of vah_add_file()
>>  virt-aa-helper: Drop cleanup label from get_files()
>>  virt-aa-helper-test: Switch to getopts
>>
>> src/logging/log_cleaner.c     |   2 +-
>> src/security/virt-aa-helper.c | 474 +++++++++++++++++-----------------
>> tests/nssmock.c               |   4 +
>> tests/qemusecuritymock.c      |   4 +
>> tests/vircgroupmock.c         |   4 +
>> tests/virfilewrapper.c        |   4 +
>> tests/virpcimock.c            |  41 ++-
>> tests/virt-aa-helper-test     |  77 +++---
>> tests/virtestmock.c           |   4 +
>> tests/virusbmock.c            |   4 +
>> 10 files changed, 353 insertions(+), 265 deletions(-)
>>
> 
> Reviewed-by: Ján Tomko <jtomko@redhat.com>

Merged, thanks.

Michal