qemu: Move config validation out of qemu_process.c

[PATCH 0/9] qemu: Move config validation out of qemu_process.c

Peter Krempa via Devel posted 9 patches 3 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1748332058.git.pkrempa@redhat.com

src/qemu/libvirtd_qemu.aug |   2 +
src/qemu/qemu.conf.in      |  42 +-----------
src/qemu/qemu_block.c      |  41 +-----------
src/qemu/qemu_conf.c       |  17 -----
src/qemu/qemu_conf.h       |   4 --
src/qemu/qemu_domain.c     | 112 +++++++++++++++----------------
src/qemu/qemu_process.c    | 132 -------------------------------------
src/qemu/qemu_validate.c   |  45 ++++++++++++-
tests/qemuxmlconftest.c    |   4 --
tests/testutilsqemu.c      |   2 -
10 files changed, 101 insertions(+), 300 deletions(-)

Expand all Fold all

[PATCH 0/9] qemu: Move config validation out of qemu_process.c

Posted by Peter Krempa via Devel 3 months, 2 weeks ago

Some more cleanups for misplaced validation of config that I've noticed
when I was looking for the code validating floppies in my previous
series.

Peter Krempa (9):
  qemuDomainValidateStorageSource: Rework protocol validation into a
    switch statement
  qemu: Move disk backend validation checks from
    qemuProcessStartValidateDisks to qemuDomainValidateStorageSource
  qemu: block: Drop code for 'vxhs' storage protocol
  qemu.conf: Document options for VxHS block network protocol TLS config
    as ignored
  qemu: conf: Drop handling of 'vxhs' config options
  qemu: Move logic from qemuProcessStartValidateShmem to
    qemuValidateDomainDeviceDefShmem
  qemu: Move checks for number of listening sockets of graphics to
    validation code
  qemuProcessStartValidateGraphics: Remove redundant checks for RDP
    protocol features
  qemuProcessStartValidateGraphics: Move RDP validation logic to
    qemu_validate.c

 src/qemu/libvirtd_qemu.aug |   2 +
 src/qemu/qemu.conf.in      |  42 +-----------
 src/qemu/qemu_block.c      |  41 +-----------
 src/qemu/qemu_conf.c       |  17 -----
 src/qemu/qemu_conf.h       |   4 --
 src/qemu/qemu_domain.c     | 112 +++++++++++++++----------------
 src/qemu/qemu_process.c    | 132 -------------------------------------
 src/qemu/qemu_validate.c   |  45 ++++++++++++-
 tests/qemuxmlconftest.c    |   4 --
 tests/testutilsqemu.c      |   2 -
 10 files changed, 101 insertions(+), 300 deletions(-)

-- 
2.49.0

Re: [PATCH 0/9] qemu: Move config validation out of qemu_process.c

Posted by Pavel Hrdina via Devel 3 months, 2 weeks ago

On Tue, May 27, 2025 at 09:48:56AM +0200, Peter Krempa via Devel wrote:
> Some more cleanups for misplaced validation of config that I've noticed
> when I was looking for the code validating floppies in my previous
> series.
> 
> Peter Krempa (9):
>   qemuDomainValidateStorageSource: Rework protocol validation into a
>     switch statement
>   qemu: Move disk backend validation checks from
>     qemuProcessStartValidateDisks to qemuDomainValidateStorageSource
>   qemu: block: Drop code for 'vxhs' storage protocol
>   qemu.conf: Document options for VxHS block network protocol TLS config
>     as ignored
>   qemu: conf: Drop handling of 'vxhs' config options
>   qemu: Move logic from qemuProcessStartValidateShmem to
>     qemuValidateDomainDeviceDefShmem
>   qemu: Move checks for number of listening sockets of graphics to
>     validation code
>   qemuProcessStartValidateGraphics: Remove redundant checks for RDP
>     protocol features
>   qemuProcessStartValidateGraphics: Move RDP validation logic to
>     qemu_validate.c

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>