[PATCH 0/4] qemu: Reflect support of floppy devices in capabilities XML

Peter Krempa via Devel posted 4 patches 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1748246185.git.pkrempa@redhat.com
src/qemu/qemu_capabilities.c                  |  6 ++-
src/qemu/qemu_capabilities.h                  |  1 +
src/qemu/qemu_domain.c                        | 15 +++++++
src/qemu/qemu_domain.h                        |  4 ++
src/qemu/qemu_process.c                       |  8 ----
src/qemu/qemu_validate.c                      |  7 +++
.../qemu_10.0.0-virt.aarch64.xml              |  2 -
tests/domaincapsdata/qemu_10.0.0.aarch64.xml  |  2 -
tests/domaincapsdata/qemu_10.0.0.s390x.xml    |  2 -
tests/domaincapsdata/qemu_8.1.0.s390x.xml     |  2 -
.../qemu_8.2.0-tcg-virt.loongarch64.xml       |  2 -
.../qemu_8.2.0-virt.aarch64.xml               |  2 -
.../qemu_8.2.0-virt.loongarch64.xml           |  2 -
tests/domaincapsdata/qemu_8.2.0.aarch64.xml   |  2 -
tests/domaincapsdata/qemu_8.2.0.armv7l.xml    |  2 -
tests/domaincapsdata/qemu_8.2.0.s390x.xml     |  2 -
.../qemu_9.1.0-tcg-virt.riscv64.xml           |  2 -
.../qemu_9.1.0-virt.riscv64.xml               |  2 -
tests/domaincapsdata/qemu_9.1.0.s390x.xml     |  2 -
.../qemu_9.2.0-hvf.aarch64+hvf.xml            |  2 -
tests/domaincapsdata/qemu_9.2.0.s390x.xml     |  2 -
.../caps_10.0.0_ppc64.xml                     |  1 +
.../caps_10.0.0_x86_64+amdsev.xml             |  1 +
.../caps_10.0.0_x86_64.xml                    |  1 +
.../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 +
.../caps_6.2.0_x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 +
.../caps_7.0.0_x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 +
.../caps_7.1.0_x86_64.xml                     |  1 +
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 +
.../caps_7.2.0_x86_64+hvf.xml                 |  1 +
.../caps_7.2.0_x86_64.xml                     |  1 +
.../caps_8.0.0_x86_64.xml                     |  1 +
.../caps_8.1.0_x86_64.xml                     |  1 +
.../caps_8.2.0_x86_64.xml                     |  1 +
.../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  1 +
.../caps_9.0.0_x86_64.xml                     |  1 +
.../caps_9.1.0_x86_64.xml                     |  1 +
.../caps_9.2.0_x86_64+amdsev.xml              |  1 +
.../caps_9.2.0_x86_64.xml                     |  1 +
.../disk-floppy-pseries.ppc64-latest.err      |  2 +-
.../disk-floppy-pseries.ppc64-latest.xml      | 44 -------------------
tests/qemuxmlconftest.c                       |  2 +-
44 files changed, 53 insertions(+), 86 deletions(-)
delete mode 100644 tests/qemuxmlconfdata/disk-floppy-pseries.ppc64-latest.xml
[PATCH 0/4] qemu: Reflect support of floppy devices in capabilities XML
Posted by Peter Krempa via Devel 3 months, 2 weeks ago
Probe if qemu actually supports floppy controllers which can be compiled
out with custom configs and reflect that in the capability XML.

Peter Krempa (4):
  qemu: domain: Introduce qemuDomainMachineSupportsFloppy
  qemu: Move floppy device support validation to validation code
  qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY
  qemuDomainMachineSupportsFloppy: Check for QEMU_CAPS_BUS_FLOPPY

 src/qemu/qemu_capabilities.c                  |  6 ++-
 src/qemu/qemu_capabilities.h                  |  1 +
 src/qemu/qemu_domain.c                        | 15 +++++++
 src/qemu/qemu_domain.h                        |  4 ++
 src/qemu/qemu_process.c                       |  8 ----
 src/qemu/qemu_validate.c                      |  7 +++
 .../qemu_10.0.0-virt.aarch64.xml              |  2 -
 tests/domaincapsdata/qemu_10.0.0.aarch64.xml  |  2 -
 tests/domaincapsdata/qemu_10.0.0.s390x.xml    |  2 -
 tests/domaincapsdata/qemu_8.1.0.s390x.xml     |  2 -
 .../qemu_8.2.0-tcg-virt.loongarch64.xml       |  2 -
 .../qemu_8.2.0-virt.aarch64.xml               |  2 -
 .../qemu_8.2.0-virt.loongarch64.xml           |  2 -
 tests/domaincapsdata/qemu_8.2.0.aarch64.xml   |  2 -
 tests/domaincapsdata/qemu_8.2.0.armv7l.xml    |  2 -
 tests/domaincapsdata/qemu_8.2.0.s390x.xml     |  2 -
 .../qemu_9.1.0-tcg-virt.riscv64.xml           |  2 -
 .../qemu_9.1.0-virt.riscv64.xml               |  2 -
 tests/domaincapsdata/qemu_9.1.0.s390x.xml     |  2 -
 .../qemu_9.2.0-hvf.aarch64+hvf.xml            |  2 -
 tests/domaincapsdata/qemu_9.2.0.s390x.xml     |  2 -
 .../caps_10.0.0_ppc64.xml                     |  1 +
 .../caps_10.0.0_x86_64+amdsev.xml             |  1 +
 .../caps_10.0.0_x86_64.xml                    |  1 +
 .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 +
 .../caps_6.2.0_x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 +
 .../caps_7.0.0_x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 +
 .../caps_7.1.0_x86_64.xml                     |  1 +
 tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 +
 .../caps_7.2.0_x86_64+hvf.xml                 |  1 +
 .../caps_7.2.0_x86_64.xml                     |  1 +
 .../caps_8.0.0_x86_64.xml                     |  1 +
 .../caps_8.1.0_x86_64.xml                     |  1 +
 .../caps_8.2.0_x86_64.xml                     |  1 +
 .../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  1 +
 .../caps_9.0.0_x86_64.xml                     |  1 +
 .../caps_9.1.0_x86_64.xml                     |  1 +
 .../caps_9.2.0_x86_64+amdsev.xml              |  1 +
 .../caps_9.2.0_x86_64.xml                     |  1 +
 .../disk-floppy-pseries.ppc64-latest.err      |  2 +-
 .../disk-floppy-pseries.ppc64-latest.xml      | 44 -------------------
 tests/qemuxmlconftest.c                       |  2 +-
 44 files changed, 53 insertions(+), 86 deletions(-)
 delete mode 100644 tests/qemuxmlconfdata/disk-floppy-pseries.ppc64-latest.xml

-- 
2.49.0
Re: [PATCH 0/4] qemu: Reflect support of floppy devices in capabilities XML
Posted by Michal Prívozník via Devel 3 months, 2 weeks ago
On 5/26/25 09:57, Peter Krempa via Devel wrote:
> Probe if qemu actually supports floppy controllers which can be compiled
> out with custom configs and reflect that in the capability XML.
> 
> Peter Krempa (4):
>   qemu: domain: Introduce qemuDomainMachineSupportsFloppy
>   qemu: Move floppy device support validation to validation code
>   qemu: capabilities: Introduce QEMU_CAPS_BUS_FLOPPY
>   qemuDomainMachineSupportsFloppy: Check for QEMU_CAPS_BUS_FLOPPY
> 

>  44 files changed, 53 insertions(+), 86 deletions(-)
>  delete mode 100644 tests/qemuxmlconfdata/disk-floppy-pseries.ppc64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal