qemu: monitor: Fix handling of 'detach' for 'migrate' and 'dump-guest-memory' QMP commands

[PATCH 0/2] qemu: monitor: Fix handling of 'detach' for 'migrate' and 'dump-guest-memory' QMP commands

Peter Krempa via Devel posted 2 patches 3 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/cover.1747814626.git.pkrempa@redhat.com

src/qemu/qemu_driver.c       | 2 +-
src/qemu/qemu_monitor.c      | 5 ++---
src/qemu/qemu_monitor.h      | 3 +--
src/qemu/qemu_monitor_json.c | 6 ++----
src/qemu/qemu_monitor_json.h | 3 +--
tests/qemumonitorjsontest.c  | 3 +--
6 files changed, 8 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH 0/2] qemu: monitor: Fix handling of 'detach' for 'migrate' and 'dump-guest-memory' QMP commands

Posted by Peter Krempa via Devel 3 months, 2 weeks ago

QEMU is deprecating 'detach' argument of 'migrate' as it was never
actually used. Drop it in libvirt as we always specify it.

The monitor handler of 'dump-guest-memory' allows controlling 'detach'
but always passes true. Libvirt doesn't want to block the monitor so
hardcode 'true' in the monitor code instead.


Peter Krempa (2):
  qemuMonitorDumpToFd: Drop 'detach' argument
  qemuMonitorJSONMigrate: Drop 'detach' QMP option

 src/qemu/qemu_driver.c       | 2 +-
 src/qemu/qemu_monitor.c      | 5 ++---
 src/qemu/qemu_monitor.h      | 3 +--
 src/qemu/qemu_monitor_json.c | 6 ++----
 src/qemu/qemu_monitor_json.h | 3 +--
 tests/qemumonitorjsontest.c  | 3 +--
 6 files changed, 8 insertions(+), 14 deletions(-)

-- 
2.49.0

Re: [PATCH 0/2] qemu: monitor: Fix handling of 'detach' for 'migrate' and 'dump-guest-memory' QMP commands

Posted by Michal Prívozník via Devel 3 months, 2 weeks ago

On 5/21/25 10:06, Peter Krempa via Devel wrote:
> QEMU is deprecating 'detach' argument of 'migrate' as it was never
> actually used. Drop it in libvirt as we always specify it.
> 
> The monitor handler of 'dump-guest-memory' allows controlling 'detach'
> but always passes true. Libvirt doesn't want to block the monitor so
> hardcode 'true' in the monitor code instead.
> 
> 
> Peter Krempa (2):
>   qemuMonitorDumpToFd: Drop 'detach' argument
>   qemuMonitorJSONMigrate: Drop 'detach' QMP option
> 
>  src/qemu/qemu_driver.c       | 2 +-
>  src/qemu/qemu_monitor.c      | 5 ++---
>  src/qemu/qemu_monitor.h      | 3 +--
>  src/qemu/qemu_monitor_json.c | 6 ++----
>  src/qemu/qemu_monitor_json.h | 3 +--
>  tests/qemumonitorjsontest.c  | 3 +--
>  6 files changed, 8 insertions(+), 14 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal