qemu: Fix regresion when loading internal snapshots and few cleanups

[PATCH 02/17] NEWS: Mention fix for internal snapshot reversion regression

Posted by Peter Krempa via Devel 3 months, 3 weeks ago

From: Peter Krempa <pkrempa@redhat.com>

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 NEWS.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/NEWS.rst b/NEWS.rst
index ad8910da4c..6cf2a47d3d 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -21,6 +21,16 @@ v11.4.0 (unreleased)

 * **Bug fixes**

+  * qemu: Fix failure when reverting to internal snapshots
+
+    Due to a regression in how libvirt starts qemu when reverting to a snapshot
+    it became impossible to revert to internal snapshots in ``libvirt-11.2`` and
+    ``libvirt-11.3`` releases. Attempts to revert would produce the following
+    error::
+
+      error: operation failed: load of internal snapshot 'foo1' job failed: Device 'libvirt-1-format' is writable but does not support snapshots
+
+    There is no workaround for this except for avoiding the broken versions.

 v11.3.0 (2025-05-02)
 ====================
-- 
2.49.0

Re: [PATCH 02/17] NEWS: Mention fix for internal snapshot reversion regression

Posted by Jim Fehlig via Devel 3 months, 3 weeks ago

On 5/15/25 09:28, Peter Krempa via Devel wrote:
> From: Peter Krempa <pkrempa@redhat.com>
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>   NEWS.rst | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index ad8910da4c..6cf2a47d3d 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -21,6 +21,16 @@ v11.4.0 (unreleased)
> 
>   * **Bug fixes**

Thanks for fixing my bug! Below are some word-smithing suggestions you're free 
to ignore :-).

> 
> +  * qemu: Fix failure when reverting to internal snapshots
> +
> +    Due to a regression in how libvirt starts qemu when reverting to a snapshot
> +    it became impossible to revert to internal snapshots in ``libvirt-11.2`` and
> +    ``libvirt-11.3`` releases. Attempts to revert would produce the following
> +    error::

A regression in libvirt-11.2 and libvirt-11.3 prevents reverting to an internal 
snapshot. Attempts to revert would produce the following error:

> +
> +      error: operation failed: load of internal snapshot 'foo1' job failed: Device 'libvirt-1-format' is writable but does not support snapshots
> +
> +    There is no workaround for this except for avoiding the broken versions.

The only workaround is to avoid the broken versions.

Either way

Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim