Resolves: https://gitlab.com/libvirt/libvirt/-/issues/770

While the original issue report describes scenario where libnl devel
package wasn't installed, it's perfectly reproducible with
-Dlibnl=disabled passed to meson.

Michal Prívozník (5):
  libvirt_private.syms: Export virNetlinkBridgeVlanFilterSet
  virnetlink: Provide stub for virNetlinkBridgeVlanFilterSet()
  virnetdevbridge.c: Fix comments in virNetDevBridgeSetupVlans()
  virnetdevbridge: Include virnetlink.h always
  virnetlink: Split virNetlinkBridgeVlanFilterSet()

 src/libvirt_private.syms   |  2 +
 src/util/virnetdevbridge.c | 18 ++++-----
 src/util/virnetlink.c      | 82 ++++++++++++++++++++++++++++++++++----
 src/util/virnetlink.h      |  5 ++-
 4 files changed, 89 insertions(+), 18 deletions(-)

-- 
2.49.0

On Mon, May 12, 2025 at 15:37:11 +0200, Michal Privoznik via Devel wrote:
> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/770
> 
> While the original issue report describes scenario where libnl devel
> package wasn't installed, it's perfectly reproducible with
> -Dlibnl=disabled passed to meson.

There was also a discussion on patches which attempted to fix this
problem a while ago, where it was discussed whether we shouldn't make
libnl mandatory for the build as the build without will be not very
usable for networking.

Anyways your series is aligned with how we handled stuff until now so I
guess this can go in and making libnl mandatory may be considered
separately.

I just wanted to point out that the user very likely wants the libnl
package installed instead.

On 5/13/25 09:46, Peter Krempa wrote:
> On Mon, May 12, 2025 at 15:37:11 +0200, Michal Privoznik via Devel wrote:
>> Resolves: https://gitlab.com/libvirt/libvirt/-/issues/770
>>
>> While the original issue report describes scenario where libnl devel
>> package wasn't installed, it's perfectly reproducible with
>> -Dlibnl=disabled passed to meson.
> 
> There was also a discussion on patches which attempted to fix this
> problem a while ago, where it was discussed whether we shouldn't make
> libnl mandatory for the build as the build without will be not very
> usable for networking.

Remember, netlink is Linux specific. We have users on *BSDs and possibly
other OSes.

> 
> Anyways your series is aligned with how we handled stuff until now so I
> guess this can go in and making libnl mandatory may be considered
> separately.
> 
> I just wanted to point out that the user very likely wants the libnl
> package installed instead.
> 

Yeah, they surely do.

Michal