Somewhat green-ish pipeline:

https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1790043585

Jobs that failed are unrelated.

Thing is, our upstream pipeline started failing on Rawhide + gcc because
of IPA. The unfortunate part is, noinline does not guarantee the
function is mockable. The fortunate part is, GCC has noipa attribute
which is even advocated for in its documentation.

Given we are after the freeze and this is potentially hazardous, I'm
okay if this is merged after the release.

Michal Prívozník (3):
  internal: Introduce ATTRIBUTE_NOIPA
  src: s/G_NO_INLINE/ATTRIBUTE_NOIPA/
  scripts: Adapt mock-noinline.py to ATTRIBUTE_NOIPA

 build-aux/syntax-check.mk                   |  4 ++--
 docs/coding-style.rst                       |  2 +-
 scripts/cocci-macro-file.h                  |  1 +
 scripts/meson.build                         |  2 +-
 scripts/{mock-noinline.py => mock-noipa.py} |  6 +++---
 src/cpu/cpu.h                               |  2 +-
 src/hypervisor/domain_interface.h           |  2 +-
 src/internal.h                              | 21 +++++++++++++++++++++
 src/libxl/libxl_capabilities.h              |  2 +-
 src/qemu/qemu_capabilities.h                |  4 ++--
 src/qemu/qemu_capspriv.h                    |  2 +-
 src/qemu/qemu_command.h                     |  6 +++---
 src/qemu/qemu_hotplug.c                     |  2 +-
 src/qemu/qemu_hotplug.h                     |  2 +-
 src/qemu/qemu_interface.h                   |  2 +-
 src/qemu/qemu_monitor.h                     |  2 +-
 src/qemu/qemu_monitor_json.h                |  2 +-
 src/qemu/qemu_monitor_priv.h                |  2 +-
 src/qemu/qemu_process.h                     |  6 +++---
 src/rpc/virnetsocket.h                      |  4 ++--
 src/util/vircgroupv2devices.h               |  2 +-
 src/util/vircommand.h                       |  2 +-
 src/util/virdevmapper.h                     |  2 +-
 src/util/virfile.h                          | 20 ++++++++++----------
 src/util/virfirewalld.h                     |  2 +-
 src/util/virhashcode.h                      |  2 +-
 src/util/virhostcpu.h                       |  8 ++++----
 src/util/virhostmem.h                       |  2 +-
 src/util/virhostuptime.h                    |  2 +-
 src/util/viridentitypriv.h                  |  2 +-
 src/util/virmacaddr.h                       |  2 +-
 src/util/virnetdev.h                        | 12 ++++++------
 src/util/virnetdevbandwidth.h               |  2 +-
 src/util/virnetdevip.h                      |  2 +-
 src/util/virnetdevmacvlan.h                 |  2 +-
 src/util/virnetdevopenvswitch.h             |  2 +-
 src/util/virnetdevtap.h                     |  6 +++---
 src/util/virnuma.h                          | 18 +++++++++---------
 src/util/virpci.h                           |  2 +-
 src/util/virprocess.h                       |  6 +++---
 src/util/virrandom.h                        |  4 ++--
 src/util/virscsi.h                          |  2 +-
 src/util/virscsivhost.h                     |  2 +-
 src/util/virtpm.h                           |  2 +-
 src/util/virutil.h                          | 16 ++++++++--------
 src/util/viruuid.h                          |  4 ++--
 46 files changed, 113 insertions(+), 91 deletions(-)
 rename scripts/{mock-noinline.py => mock-noipa.py} (93%)

-- 
2.49.0

On Mon, Apr 28, 2025 at 03:20:55PM +0200, Michal Privoznik via Devel wrote:
> Somewhat green-ish pipeline:
> 
> https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1790043585
> 
> Jobs that failed are unrelated.
> 
> Thing is, our upstream pipeline started failing on Rawhide + gcc because
> of IPA. The unfortunate part is, noinline does not guarantee the
> function is mockable. The fortunate part is, GCC has noipa attribute
> which is even advocated for in its documentation.

Took a while to dig into history of this, as I know we debated
noipa in the past. AFAICT, we decided NOT to use noipa solely
because it was a GCC only solution, but despite that, we ended
up having to use add a CLang-only solution anyway in the form
of -fsemantic-interposition. Given the latter, and that we have
long known 'noinline' was insufficient, it makes sense to finally
use 'noipa' on GCC.

> Given we are after the freeze and this is potentially hazardous, I'm
> okay if this is merged after the release.

Yeah, probably best to wait until next cycle, as we've got a long
history of unexpected edge cases with mocking & interactions with
compiler optimization. Would be good to have a cycle to debug any
possible fallout.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|