[PATCH 1/2] util: Add missing G_NO_INLINE annotation

Michal Privoznik via Devel posted 2 patches 7 months, 3 weeks ago
[PATCH 1/2] util: Add missing G_NO_INLINE annotation
Posted by Michal Privoznik via Devel 7 months, 3 weeks ago
From: Michal Privoznik <mprivozn@redhat.com>

There are two functions that are mocked, but are missing required
G_NO_INLINE attribute: virFirewallDIsRegistered() and
virHostCPUGetPhysAddrSize(). Add it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/util/virfirewalld.h | 2 +-
 src/util/virhostcpu.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/util/virfirewalld.h b/src/util/virfirewalld.h
index 43803ee89a..2c7d3e22cd 100644
--- a/src/util/virfirewalld.h
+++ b/src/util/virfirewalld.h
@@ -33,7 +33,7 @@ typedef enum {
 
 int virFirewallDGetVersion(unsigned long long *version);
 int virFirewallDGetBackend(void);
-int virFirewallDIsRegistered(void);
+int virFirewallDIsRegistered(void) G_NO_INLINE;
 int virFirewallDGetZones(char ***zones, size_t *nzones);
 int virFirewallDGetPolicies(char ***policies, size_t *npolicies);
 bool virFirewallDZoneExists(const char *match);
diff --git a/src/util/virhostcpu.h b/src/util/virhostcpu.h
index 1f47634c33..92db35232b 100644
--- a/src/util/virhostcpu.h
+++ b/src/util/virhostcpu.h
@@ -90,7 +90,7 @@ virHostCPUTscInfo *virHostCPUGetTscInfo(void);
 int virHostCPUGetSignature(char **signature);
 
 int virHostCPUGetPhysAddrSize(const virArch hostArch,
-                              unsigned int *size);
+                              unsigned int *size) G_NO_INLINE;
 
 int virHostCPUGetHaltPollTime(pid_t pid,
                               unsigned long long *haltPollSuccess,
-- 
2.49.0
Re: [PATCH 1/2] util: Add missing G_NO_INLINE annotation
Posted by Daniel P. Berrangé via Devel 7 months, 3 weeks ago
On Mon, Apr 28, 2025 at 01:47:49PM +0200, Michal Privoznik via Devel wrote:
> From: Michal Privoznik <mprivozn@redhat.com>
> 
> There are two functions that are mocked, but are missing required
> G_NO_INLINE attribute: virFirewallDIsRegistered() and
> virHostCPUGetPhysAddrSize(). Add it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/util/virfirewalld.h | 2 +-
>  src/util/virhostcpu.h   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|