Decrease stack size below 2048 bytes

[PATCH 8/8] meson: Drop workaround for -Wframe-larger-than and clang

Posted by Michal Privoznik via Devel 8 months, 2 weeks ago

From: Michal Privoznik <mprivozn@redhat.com>

After previous cleanups, all functions have their stack smaller
than 2048 bytes and thus the workaround is no longer needed.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 meson.build | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/meson.build b/meson.build
index bf4a245dd3..37b1caa566 100644
--- a/meson.build
+++ b/meson.build
@@ -258,11 +258,6 @@ alloc_max = run_command(
 
 stack_frame_size = 2048
 
-# clang without optimization enlarges stack frames in certain corner cases
-if cc.get_id() == 'clang' and get_option('optimization') == '0'
-    stack_frame_size = 4096
-endif
-
 # sanitizer instrumentation may enlarge stack frames
 if get_option('b_sanitize') != 'none'
   stack_frame_size = 32768
-- 
2.49.0

Re: [PATCH 8/8] meson: Drop workaround for -Wframe-larger-than and clang

Posted by Roman Bogorodskiy 8 months, 2 weeks ago

  Michal Privoznik via Devel wrote:

> From: Michal Privoznik <mprivozn@redhat.com>
> 
> After previous cleanups, all functions have their stack smaller
> than 2048 bytes and thus the workaround is no longer needed.

Thanks, now that works for me too.

Reviewed-by: Roman Bogorodskiy <bogorodskiy@gmail.com>

> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  meson.build | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index bf4a245dd3..37b1caa566 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -258,11 +258,6 @@ alloc_max = run_command(
>  
>  stack_frame_size = 2048
>  
> -# clang without optimization enlarges stack frames in certain corner cases
> -if cc.get_id() == 'clang' and get_option('optimization') == '0'
> -    stack_frame_size = 4096
> -endif
> -
>  # sanitizer instrumentation may enlarge stack frames
>  if get_option('b_sanitize') != 'none'
>    stack_frame_size = 32768
> -- 
> 2.49.0