cpu_map: Install Ampere-1 ARM CPU models

[PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

Posted by Jiri Denemark via Devel 8 months, 2 weeks ago

BTW, the added test will not actually detect similar issues in the
future (I'm thinking about such test, though), but it will help with
other issues with the ARM CPU map as it hasn't been covered at all.

Jiri Denemark (3):
  tests: Add a basic CPU test for aarch64
  cpu_map: Install Ampere-1 ARM CPU models
  NEWS: Document ARM CPU map bug fix

 NEWS.rst                            |  6 +++++
 src/cpu_map/meson.build             |  2 ++
 tests/cputest.c                     | 35 +++++++++++++++++++++++++++++
 tests/cputestdata/aarch64-guest.xml |  4 ++++
 4 files changed, 47 insertions(+)
 create mode 100644 tests/cputestdata/aarch64-guest.xml

-- 
2.49.0

Re: [PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

Posted by Michal Prívozník via Devel 8 months, 1 week ago

On 4/4/25 14:49, Jiri Denemark via Devel wrote:
> BTW, the added test will not actually detect similar issues in the
> future (I'm thinking about such test, though), but it will help with
> other issues with the ARM CPU map as it hasn't been covered at all.
> 
> Jiri Denemark (3):
>   tests: Add a basic CPU test for aarch64
>   cpu_map: Install Ampere-1 ARM CPU models
>   NEWS: Document ARM CPU map bug fix
> 
>  NEWS.rst                            |  6 +++++
>  src/cpu_map/meson.build             |  2 ++
>  tests/cputest.c                     | 35 +++++++++++++++++++++++++++++
>  tests/cputestdata/aarch64-guest.xml |  4 ++++
>  4 files changed, 47 insertions(+)
>  create mode 100644 tests/cputestdata/aarch64-guest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

Re: [PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

Posted by Daniel P. Berrangé via Devel 8 months, 2 weeks ago

On Fri, Apr 04, 2025 at 02:49:57PM +0200, Jiri Denemark via Devel wrote:
> BTW, the added test will not actually detect similar issues in the
> future (I'm thinking about such test, though), but it will help with
> other issues with the ARM CPU map as it hasn't been covered at all.

A test that parses the cpu_map.xml file and the src/cpu_map/meson.buld
file and checks that every map entry is also listed in meson


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models

Posted by Jiří Denemark via Devel 8 months, 2 weeks ago

On Fri, Apr 04, 2025 at 14:07:39 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 04, 2025 at 02:49:57PM +0200, Jiri Denemark via Devel wrote:
> > BTW, the added test will not actually detect similar issues in the
> > future (I'm thinking about such test, though), but it will help with
> > other issues with the ARM CPU map as it hasn't been covered at all.
> 
> A test that parses the cpu_map.xml file and the src/cpu_map/meson.buld
> file and checks that every map entry is also listed in meson

Yes. I was even thinking about checking xml files in the src/cpu_map
directory.

Jirka