[PATCH 0/6] qemu: Remove last HMP commands

Peter Krempa via Devel posted 6 patches 8 months, 2 weeks ago
Failed in applying to current master (apply log)
po/POTFILES                                   |  1 -
src/qemu/meson.build                          |  1 -
src/qemu/qemu_capabilities.c                  |  3 +-
src/qemu/qemu_capabilities.h                  |  2 +-
src/qemu/qemu_command.c                       |  6 --
src/qemu/qemu_domain.c                        |  7 +-
src/qemu/qemu_monitor.c                       | 25 ------
src/qemu/qemu_monitor.h                       |  3 -
src/qemu/qemu_monitor_text.c                  | 88 -------------------
src/qemu/qemu_monitor_text.h                  | 29 ------
src/qemu/qemu_process.c                       |  3 +-
src/qemu/qemu_snapshot.c                      | 49 ++---------
.../caps_10.0.0_s390x.xml                     |  1 -
.../caps_10.0.0_x86_64+amdsev.xml             |  1 -
.../caps_10.0.0_x86_64.xml                    |  1 -
.../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 -
.../caps_6.2.0_x86_64.xml                     |  1 -
.../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 -
.../caps_7.0.0_x86_64.xml                     |  1 -
.../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 -
.../caps_7.1.0_x86_64.xml                     |  1 -
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 -
.../caps_7.2.0_x86_64+hvf.xml                 |  1 -
.../caps_7.2.0_x86_64.xml                     |  1 -
.../caps_8.0.0_x86_64.xml                     |  1 -
.../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  1 -
.../caps_8.1.0_x86_64.xml                     |  1 -
.../caps_8.2.0_aarch64.xml                    |  1 -
.../caps_8.2.0_armv7l.xml                     |  1 -
.../caps_8.2.0_loongarch64.xml                |  1 -
.../qemucapabilitiesdata/caps_8.2.0_s390x.xml |  1 -
.../caps_8.2.0_x86_64.xml                     |  1 -
.../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  1 -
.../caps_9.0.0_x86_64.xml                     |  1 -
.../caps_9.1.0_riscv64.xml                    |  1 -
.../qemucapabilitiesdata/caps_9.1.0_s390x.xml |  1 -
.../caps_9.1.0_x86_64.xml                     |  1 -
.../caps_9.2.0_aarch64+hvf.xml                |  1 -
.../qemucapabilitiesdata/caps_9.2.0_s390x.xml |  1 -
.../caps_9.2.0_x86_64+amdsev.xml              |  1 -
.../caps_9.2.0_x86_64.xml                     |  1 -
41 files changed, 15 insertions(+), 231 deletions(-)
delete mode 100644 src/qemu/qemu_monitor_text.c
delete mode 100644 src/qemu/qemu_monitor_text.h
[PATCH 0/6] qemu: Remove last HMP commands
Posted by Peter Krempa via Devel 8 months, 2 weeks ago
RIP HMP use in libvirt:

 2007-02-14 [1] - 2025-04-02

[1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948

Peter Krempa (6):
  qemu: domain: Don't check return value of 'virCPUDefCopy'
  qemuSnapshotCreateActiveInternal: Fix error logic
  qemu: snapshot: Always assume support for
    QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
  qemu: Always revert internal snapshots via QMP rather than '-loadvm'
  qemu: monitor: Remove HMP monitor code
  qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP

 po/POTFILES                                   |  1 -
 src/qemu/meson.build                          |  1 -
 src/qemu/qemu_capabilities.c                  |  3 +-
 src/qemu/qemu_capabilities.h                  |  2 +-
 src/qemu/qemu_command.c                       |  6 --
 src/qemu/qemu_domain.c                        |  7 +-
 src/qemu/qemu_monitor.c                       | 25 ------
 src/qemu/qemu_monitor.h                       |  3 -
 src/qemu/qemu_monitor_text.c                  | 88 -------------------
 src/qemu/qemu_monitor_text.h                  | 29 ------
 src/qemu/qemu_process.c                       |  3 +-
 src/qemu/qemu_snapshot.c                      | 49 ++---------
 .../caps_10.0.0_s390x.xml                     |  1 -
 .../caps_10.0.0_x86_64+amdsev.xml             |  1 -
 .../caps_10.0.0_x86_64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml |  1 -
 .../caps_6.2.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml |  1 -
 .../caps_7.0.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml |  1 -
 .../caps_7.1.0_x86_64.xml                     |  1 -
 tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml |  1 -
 .../caps_7.2.0_x86_64+hvf.xml                 |  1 -
 .../caps_7.2.0_x86_64.xml                     |  1 -
 .../caps_8.0.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_8.1.0_s390x.xml |  1 -
 .../caps_8.1.0_x86_64.xml                     |  1 -
 .../caps_8.2.0_aarch64.xml                    |  1 -
 .../caps_8.2.0_armv7l.xml                     |  1 -
 .../caps_8.2.0_loongarch64.xml                |  1 -
 .../qemucapabilitiesdata/caps_8.2.0_s390x.xml |  1 -
 .../caps_8.2.0_x86_64.xml                     |  1 -
 .../qemucapabilitiesdata/caps_9.0.0_sparc.xml |  1 -
 .../caps_9.0.0_x86_64.xml                     |  1 -
 .../caps_9.1.0_riscv64.xml                    |  1 -
 .../qemucapabilitiesdata/caps_9.1.0_s390x.xml |  1 -
 .../caps_9.1.0_x86_64.xml                     |  1 -
 .../caps_9.2.0_aarch64+hvf.xml                |  1 -
 .../qemucapabilitiesdata/caps_9.2.0_s390x.xml |  1 -
 .../caps_9.2.0_x86_64+amdsev.xml              |  1 -
 .../caps_9.2.0_x86_64.xml                     |  1 -
 41 files changed, 15 insertions(+), 231 deletions(-)
 delete mode 100644 src/qemu/qemu_monitor_text.c
 delete mode 100644 src/qemu/qemu_monitor_text.h

-- 
2.49.0
Re: [PATCH 0/6] qemu: Remove last HMP commands
Posted by Pavel Hrdina via Devel 8 months, 2 weeks ago
On Wed, Apr 02, 2025 at 10:08:23AM +0200, Peter Krempa via Devel wrote:
> RIP HMP use in libvirt:
> 
>  2007-02-14 [1] - 2025-04-02
> 
> [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
> 
> Peter Krempa (6):
>   qemu: domain: Don't check return value of 'virCPUDefCopy'
>   qemuSnapshotCreateActiveInternal: Fix error logic
>   qemu: snapshot: Always assume support for
>     QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
>   qemu: Always revert internal snapshots via QMP rather than '-loadvm'
>   qemu: monitor: Remove HMP monitor code
>   qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Re: [PATCH 0/6] qemu: Remove last HMP commands
Posted by Ján Tomko via Devel 8 months, 2 weeks ago
On a Wednesday in 2025, Peter Krempa via Devel wrote:
>RIP HMP use in libvirt:
>
> 2007-02-14 [1] - 2025-04-02
>
>[1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
>
>Peter Krempa (6):
>  qemu: domain: Don't check return value of 'virCPUDefCopy'
>  qemuSnapshotCreateActiveInternal: Fix error logic
>  qemu: snapshot: Always assume support for
>    QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
>  qemu: Always revert internal snapshots via QMP rather than '-loadvm'
>  qemu: monitor: Remove HMP monitor code
>  qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Celebrated-by: Ján Tomko <jtomko@redhat.com>

Jano