[PATCH 0/8] Support FD passing for the NBD server socket used for backup

Peter Krempa via Devel posted 8 patches 8 months, 3 weeks ago
Failed in applying to current master (apply log)
docs/formatbackup.rst                         | 21 +++++
src/conf/backup_conf.c                        |  3 +-
src/conf/domain_conf.c                        | 93 ++++++++++++-------
src/conf/domain_conf.h                        |  3 +-
src/conf/schemas/domainbackup.rng             |  6 ++
src/conf/storage_source_conf.c                | 20 ++--
src/conf/storage_source_conf.h                |  7 +-
src/libvirt_private.syms                      |  1 -
src/qemu/qemu_backup.c                        | 28 ++++++
src/qemu/qemu_block.c                         |  1 +
src/qemu/qemu_monitor.c                       |  2 +-
src/qemu/qemu_monitor_json.c                  | 21 +++++
.../storage_file_backend_gluster.c            |  1 +
.../domainbackupxml2xmlin/backup-pull-fd.xml  | 22 +++++
.../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++++
tests/genericxml2xmltest.c                    |  1 +
16 files changed, 198 insertions(+), 55 deletions(-)
create mode 100644 tests/domainbackupxml2xmlin/backup-pull-fd.xml
create mode 100644 tests/domainbackupxml2xmlout/backup-pull-fd.xml
[PATCH 0/8] Support FD passing for the NBD server socket used for backup
Posted by Peter Krempa via Devel 8 months, 3 weeks ago
See 6/8 for justification.

Peter Krempa (8):
  virDomainStorageNetworkParseHost: Remove unpopulated 'transport'
    variable
  virDomainStorageNetworkParseHost: Refactor cleanup
  conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD
  virStorageNetHostDefClear: Move into virStorageNetHostDefFree
  qemu: monitor: Support FD passing of sockets to
    'qemuMonitorJSONNBDServerStart'
  backup: Add support for passing server socket file descriptor to
    backup NBD server
  tests: domainbackupxml2xml: Add test case for pull-mode backup with
    NBD transport='fd'
  qemu: monitor: Improve field annotations in QEMU_CHECK_MONITOR

 docs/formatbackup.rst                         | 21 +++++
 src/conf/backup_conf.c                        |  3 +-
 src/conf/domain_conf.c                        | 93 ++++++++++++-------
 src/conf/domain_conf.h                        |  3 +-
 src/conf/schemas/domainbackup.rng             |  6 ++
 src/conf/storage_source_conf.c                | 20 ++--
 src/conf/storage_source_conf.h                |  7 +-
 src/libvirt_private.syms                      |  1 -
 src/qemu/qemu_backup.c                        | 28 ++++++
 src/qemu/qemu_block.c                         |  1 +
 src/qemu/qemu_monitor.c                       |  2 +-
 src/qemu/qemu_monitor_json.c                  | 21 +++++
 .../storage_file_backend_gluster.c            |  1 +
 .../domainbackupxml2xmlin/backup-pull-fd.xml  | 22 +++++
 .../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++++
 tests/genericxml2xmltest.c                    |  1 +
 16 files changed, 198 insertions(+), 55 deletions(-)
 create mode 100644 tests/domainbackupxml2xmlin/backup-pull-fd.xml
 create mode 100644 tests/domainbackupxml2xmlout/backup-pull-fd.xml

-- 
2.49.0
Re: [PATCH 0/8] Support FD passing for the NBD server socket used for backup
Posted by Ján Tomko via Devel 8 months, 2 weeks ago
On a Friday in 2025, Peter Krempa via Devel wrote:
>See 6/8 for justification.
>
>Peter Krempa (8):
>  virDomainStorageNetworkParseHost: Remove unpopulated 'transport'
>    variable
>  virDomainStorageNetworkParseHost: Refactor cleanup
>  conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD
>  virStorageNetHostDefClear: Move into virStorageNetHostDefFree
>  qemu: monitor: Support FD passing of sockets to
>    'qemuMonitorJSONNBDServerStart'
>  backup: Add support for passing server socket file descriptor to
>    backup NBD server
>  tests: domainbackupxml2xml: Add test case for pull-mode backup with
>    NBD transport='fd'
>  qemu: monitor: Improve field annotations in QEMU_CHECK_MONITOR
>
> docs/formatbackup.rst                         | 21 +++++
> src/conf/backup_conf.c                        |  3 +-
> src/conf/domain_conf.c                        | 93 ++++++++++++-------
> src/conf/domain_conf.h                        |  3 +-
> src/conf/schemas/domainbackup.rng             |  6 ++
> src/conf/storage_source_conf.c                | 20 ++--
> src/conf/storage_source_conf.h                |  7 +-
> src/libvirt_private.syms                      |  1 -
> src/qemu/qemu_backup.c                        | 28 ++++++
> src/qemu/qemu_block.c                         |  1 +
> src/qemu/qemu_monitor.c                       |  2 +-
> src/qemu/qemu_monitor_json.c                  | 21 +++++
> .../storage_file_backend_gluster.c            |  1 +
> .../domainbackupxml2xmlin/backup-pull-fd.xml  | 22 +++++
> .../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++++
> tests/genericxml2xmltest.c                    |  1 +
> 16 files changed, 198 insertions(+), 55 deletions(-)
> create mode 100644 tests/domainbackupxml2xmlin/backup-pull-fd.xml
> create mode 100644 tests/domainbackupxml2xmlout/backup-pull-fd.xml
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano