Unused cleanups

[libvirt PATCH 04/10] qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine

Posted by Ján Tomko 9 months, 1 week ago

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_command.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index ae187dac78..4f0a9a517c 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1220,8 +1220,7 @@ qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo,
  */
 static int
 qemuBuildObjectSecretCommandLine(virCommand *cmd,
-                                 qemuDomainSecretInfo *secinfo,
-                                 virQEMUCaps *qemuCaps G_GNUC_UNUSED)
+                                 qemuDomainSecretInfo *secinfo)
 {
     g_autoptr(virJSONValue) props = NULL;
 
@@ -1323,8 +1322,7 @@ qemuBuildChardevCommand(virCommand *cmd,
              * functions can just check the config fields */
             if (chrSourcePriv->secinfo) {
                 if (qemuBuildObjectSecretCommandLine(cmd,
-                                                     chrSourcePriv->secinfo,
-                                                     qemuCaps) < 0)
+                                                     chrSourcePriv->secinfo) < 0)
                     return -1;
 
                 tlsCertEncSecAlias = chrSourcePriv->secinfo->alias;
@@ -8099,8 +8097,7 @@ qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfig *cfg,
 
         if (gfxPriv->secinfo) {
             if (qemuBuildObjectSecretCommandLine(cmd,
-                                                 gfxPriv->secinfo,
-                                                 qemuCaps) < 0)
+                                                 gfxPriv->secinfo) < 0)
                 return -1;
             secretAlias = gfxPriv->secinfo->alias;
         }
-- 
2.48.1

Re: [libvirt PATCH 04/10] qemu: remove qemuCaps from qemuBuildObjectSecretCommandLine

Posted by Peter Krempa 9 months, 1 week ago

On Thu, Mar 13, 2025 at 16:30:18 +0100, Ján Tomko wrote:
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_command.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index ae187dac78..4f0a9a517c 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1220,8 +1220,7 @@ qemuBuildSecretInfoProps(qemuDomainSecretInfo *secinfo,
>   */

'qemuCaps' is documented in the funcion comment above this block.