The shutdown inhibitor is created in networkStateInitialize() but
corresponding call to virInhibitorFree() is missing in
networkStateCleanup() leading to a memleak:

116 (72 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 1,769 of 1,998
   at 0x484CEF3: calloc (vg_replace_malloc.c:1675)
   by 0x4F0E7A9: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.8000.5)
   by 0x4993B9B: virInhibitorNew (virinhibitor.c:152)
   by 0x5279394: networkStateInitialize (bridge_driver.c:654)
   by 0x4CC74DC: virStateInitialize (libvirt.c:665)
   by 0x15B719: daemonRunStateInit (remote_daemon.c:613)
   by 0x49F2B44: virThreadHelper (virthread.c:256)
   by 0x5356662: start_thread (in /usr/lib64/libc.so.6)
   by 0x53D7DA3: clone (in /usr/lib64/libc.so.6)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/network/bridge_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 80d2c3a1d5..2cad1c8cbe 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -802,6 +802,8 @@ networkStateCleanup(void)
                           network_driver->lockFD);
     }
 
+    virInhibitorFree(network_driver->inhibitor);
+
     virObjectUnref(network_driver->config);
     virObjectUnref(network_driver->dnsmasqCaps);
 
-- 
2.48.1

On Thu, Mar 13, 2025 at 14:44:33 +0100, Michal Privoznik wrote:
> The shutdown inhibitor is created in networkStateInitialize() but
> corresponding call to virInhibitorFree() is missing in
> networkStateCleanup() leading to a memleak:

good that it's a "singleton"

> 
> 116 (72 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 1,769 of 1,998
>    at 0x484CEF3: calloc (vg_replace_malloc.c:1675)
>    by 0x4F0E7A9: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.8000.5)
>    by 0x4993B9B: virInhibitorNew (virinhibitor.c:152)
>    by 0x5279394: networkStateInitialize (bridge_driver.c:654)
>    by 0x4CC74DC: virStateInitialize (libvirt.c:665)
>    by 0x15B719: daemonRunStateInit (remote_daemon.c:613)
>    by 0x49F2B44: virThreadHelper (virthread.c:256)
>    by 0x5356662: start_thread (in /usr/lib64/libc.so.6)
>    by 0x53D7DA3: clone (in /usr/lib64/libc.so.6)
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/network/bridge_driver.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>