[libvirt PATCH 07/16] domain_conf: graphics: extract Desktop formatting to separate function

Pavel Hrdina posted 16 patches 6 days ago
[libvirt PATCH 07/16] domain_conf: graphics: extract Desktop formatting to separate function
Posted by Pavel Hrdina 6 days ago
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
---
 src/conf/domain_conf.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 9400206e8f..3edeffbe72 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -26494,6 +26494,16 @@ virDomainGraphicsDefFormatRDP(virBuffer *attrBuf,
     virDomainGraphicsListenDefFormatAddr(attrBuf, glisten, flags);
 }
 
+static void
+virDomainGraphicsDefFormatDesktop(virBuffer *attrBuf,
+                                  virDomainGraphicsDef *def)
+{
+    virBufferEscapeString(attrBuf, " display='%s'", def->data.desktop.display);
+
+    if (def->data.desktop.fullscreen)
+        virBufferAddLit(attrBuf, " fullscreen='yes'");
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26528,12 +26538,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP:
-        virBufferEscapeString(&attrBuf, " display='%s'",
-                              def->data.desktop.display);
-
-        if (def->data.desktop.fullscreen)
-            virBufferAddLit(&attrBuf, " fullscreen='yes'");
-
+        virDomainGraphicsDefFormatDesktop(&attrBuf, def);
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_SPICE:
-- 
2.48.1