I'm drawing blanks when it comes to commit messages today.  But this still has
time, because even though the patches are in QEMU upstream, but not a part of a
release yet.  However nothing should break if we add support earlier...
Right? O:-)

v2:
 - split patches
 - add it to guestinfo instead of domstats
 - some more macro deduplication

Martin Kletzander (4):
  Add load average information type into virDomainGetGuestInfo
  qemu_agent: Add qemuAgentGetLoadAvg()
  qemu: Add support for VIR_DOMAIN_GUEST_INFO_LOAD
  virsh: Add support for VIR_DOMAIN_GUEST_INFO_LOAD

 docs/manpages/virsh.rst          |  8 ++++-
 include/libvirt/libvirt-domain.h |  1 +
 src/libvirt-domain.c             |  8 +++++
 src/qemu/qemu_agent.c            | 55 ++++++++++++++++++++++++++++++++
 src/qemu/qemu_agent.h            |  6 ++++
 src/qemu/qemu_driver.c           | 21 +++++++++++-
 tests/qemuagenttest.c            | 53 ++++++++++++++++++++++++++++++
 tools/virsh-domain.c             |  6 ++++
 8 files changed, 156 insertions(+), 2 deletions(-)

-- 
2.48.1

On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote:
> I'm drawing blanks when it comes to commit messages today.  But this still has
> time, because even though the patches are in QEMU upstream, but not a part of a
> release yet.  However nothing should break if we add support earlier...
> Right? O:-)

No it doesn't qualify to be pushed during freeze ;)

> 
> v2:
>  - split patches
>  - add it to guestinfo instead of domstats
>  - some more macro deduplication
> 
> Martin Kletzander (4):
>   Add load average information type into virDomainGetGuestInfo
>   qemu_agent: Add qemuAgentGetLoadAvg()
>   qemu: Add support for VIR_DOMAIN_GUEST_INFO_LOAD
>   virsh: Add support for VIR_DOMAIN_GUEST_INFO_LOAD

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote:
>On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote:
>> I'm drawing blanks when it comes to commit messages today.  But this still has
>> time, because even though the patches are in QEMU upstream, but not a part of a
>> release yet.  However nothing should break if we add support earlier...
>> Right? O:-)
>
>No it doesn't qualify to be pushed during freeze ;)
>

I meant earlier as in "before it's released in qemu" not "during
freeze", I even specifically mention 11.2.0 in the docs ;)

>>
>> v2:
>>  - split patches
>>  - add it to guestinfo instead of domstats
>>  - some more macro deduplication
>>
>> Martin Kletzander (4):
>>   Add load average information type into virDomainGetGuestInfo
>>   qemu_agent: Add qemuAgentGetLoadAvg()
>>   qemu: Add support for VIR_DOMAIN_GUEST_INFO_LOAD
>>   virsh: Add support for VIR_DOMAIN_GUEST_INFO_LOAD
>
>Reviewed-by: Peter Krempa <pkrempa@redhat.com>
>

Thanks, I'll fixup what you suggested and wait for after the release.

On Tue, Feb 25, 2025 at 17:17:46 +0100, Martin Kletzander wrote:
> On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote:
> > On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote:
> > > I'm drawing blanks when it comes to commit messages today.  But this still has
> > > time, because even though the patches are in QEMU upstream, but not a part of a
> > > release yet.  However nothing should break if we add support earlier...
> > > Right? O:-)
> > 
> > No it doesn't qualify to be pushed during freeze ;)
> > 
> 
> I meant earlier as in "before it's released in qemu" not "during
> freeze", I even specifically mention 11.2.0 in the docs ;)

You see cover-letters are pointless because nobody reads them properly.

Anyways we do integration with pushed-but-not-yet-released qemu stuff
all the time so there's definitely precedent. And stuff gets changed;
libvirt can still adapt it without breaking compatibility.

On a Tuesday in 2025, Peter Krempa wrote:
>On Tue, Feb 25, 2025 at 17:17:46 +0100, Martin Kletzander wrote:
>> On Tue, Feb 25, 2025 at 05:02:35PM +0100, Peter Krempa wrote:
>> > On Tue, Feb 25, 2025 at 15:52:28 +0100, Martin Kletzander wrote:
>> > > I'm drawing blanks when it comes to commit messages today.  But this still has
>> > > time, because even though the patches are in QEMU upstream, but not a part of a
>> > > release yet.  However nothing should break if we add support earlier...
>> > > Right? O:-)
>> >
>> > No it doesn't qualify to be pushed during freeze ;)
>> >
>>
>> I meant earlier as in "before it's released in qemu" not "during
>> freeze", I even specifically mention 11.2.0 in the docs ;)
>
>You see cover-letters are pointless because nobody reads them properly.
>
>Anyways we do integration with pushed-but-not-yet-released qemu stuff
>all the time so there's definitely precedent. And stuff gets changed;
>libvirt can still adapt it without breaking compatibility.
>

I think that only happened in a handful of cases in the past.

Also, there's still almost 5 weeks until the release of 11.2.0 so plenty
of time to change stuff.

Jano