On 2/20/25 16:26, Jiri Denemark wrote:
> This series originally started as a documentation update for
> hypervisor-cpu-compare and hypervisor-cpu-baseline commands with an idea
> to print a warning if the commands are used suboptimally. The rest is a
> refactor and a lot of fixes of (mostly) error messages printed by virsh.
>
> Jiri Denemark (13):
> docs: Clarify documentation of virsh hypervisor-cpu-compare
> docs: Clarify documentation of virsh hypervisor-cpu-baseline
> virsh: Do not format messages twice
> virsh: Make messages printed by vshError properly translatable
> virsh: Refactor vshError
> virsh: Introduce vshWarn
> virsh: Warn when hypervisor-cpu-* is used with host CPU
> virsh: Do not require \n in vshDebug messages
> virsh: Properly mark all error messages for translation
> virsh: Avoid using translated messages without format
> virsh: Drop extra newlines at the end of error messages
> virsh: Let prohibit_newline_at_end_of_diagnostic check pass
> build: Enable syntax checks for vshError and vshWarn
>
> build-aux/syntax-check.mk | 3 +-
> docs/manpages/virsh.rst | 47 ++++++++-----
> tools/virsh-domain-monitor.c | 16 ++---
> tools/virsh-domain.c | 131 ++++++++++++++++++-----------------
> tools/virsh-host.c | 22 ++++--
> tools/virsh-interface.c | 6 +-
> tools/virsh-network.c | 10 +--
> tools/virsh-nodedev.c | 6 +-
> tools/virsh-nwfilter.c | 10 +--
> tools/virsh-pool.c | 10 +--
> tools/virsh-secret.c | 8 +--
> tools/virsh-snapshot.c | 12 ++--
> tools/virsh-util.c | 16 ++---
> tools/virsh-volume.c | 24 +++----
> tools/virsh.c | 10 +--
> tools/virt-admin.c | 16 ++---
> tools/vsh.c | 113 +++++++++++++++++-------------
> tools/vsh.h | 6 +-
> 18 files changed, 254 insertions(+), 212 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal