[PATCH v2 10/15] libxlDomainGetMessages: Add existing flags to 'virCheckFlags'

Peter Krempa posted 15 patches 7 months, 1 week ago
[PATCH v2 10/15] libxlDomainGetMessages: Add existing flags to 'virCheckFlags'
Posted by Peter Krempa 7 months, 1 week ago
The two VIR_DOMAIN_MESSAGE_* flags were not listed in the virCheckFlags
check in 'libxl' but were present in 'test' and 'qemu' driver impls.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
---
 src/libxl/libxl_driver.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c
index 494b1ad9bc..058fee0706 100644
--- a/src/libxl/libxl_driver.c
+++ b/src/libxl/libxl_driver.c
@@ -6578,7 +6578,8 @@ libxlDomainGetMessages(virDomainPtr dom,
     virDomainObj *vm = NULL;
     int ret = -1;

-    virCheckFlags(0, -1);
+    virCheckFlags(VIR_DOMAIN_MESSAGE_DEPRECATION |
+                  VIR_DOMAIN_MESSAGE_TAINTING, -1);

     if (!(vm = libxlDomObjFromDomain(dom)))
         return -1;
-- 
2.48.1
Re: [PATCH v2 10/15] libxlDomainGetMessages: Add existing flags to 'virCheckFlags'
Posted by Daniel P. Berrangé 7 months, 1 week ago
On Tue, Jan 28, 2025 at 05:28:14PM +0100, Peter Krempa wrote:
> The two VIR_DOMAIN_MESSAGE_* flags were not listed in the virCheckFlags
> check in 'libxl' but were present in 'test' and 'qemu' driver impls.
> 
> Signed-off-by: Peter Krempa <pkrempa@redhat.com>
> ---
>  src/libxl/libxl_driver.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|