[v1] Enable virtio-mem-ccw

[PATCH 6/8] qemu: Allow virtio-mem on CCW

Posted by Michal Privoznik 7 months, 2 weeks ago

After previous commits, we can allow virtio-mem to live on CCW
channel.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 6554b992f0..56f86140cd 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -7673,9 +7673,10 @@ qemuDomainDefValidateMemoryHotplugDevice(const virDomainMemoryDef *mem,
 
     case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
         if (mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
+            mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW &&
             mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
-                           _("only 'pci' addresses are supported for the %1$s device"),
+                           _("only 'pci' and 'ccw' addresses are supported for the %1$s device"),
                            virDomainMemoryModelTypeToString(mem->model));
             return -1;
         }
-- 
2.45.2

Re: [PATCH 6/8] qemu: Allow virtio-mem on CCW

Posted by Boris Fiuczynski 7 months, 2 weeks ago

Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

On 1/24/25 13:21, Michal Privoznik wrote:
> After previous commits, we can allow virtio-mem to live on CCW
> channel.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>   src/qemu/qemu_domain.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 6554b992f0..56f86140cd 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -7673,9 +7673,10 @@ qemuDomainDefValidateMemoryHotplugDevice(const virDomainMemoryDef *mem,
>   
>       case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM:
>           if (mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
> +            mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW &&
>               mem->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
>               virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> -                           _("only 'pci' addresses are supported for the %1$s device"),
> +                           _("only 'pci' and 'ccw' addresses are supported for the %1$s device"),
>                              virDomainMemoryModelTypeToString(mem->model));
>               return -1;
>           }


-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294