This is an example test for virtio-mem on s390. Currently, both
virtio-mem devices are placed onto PCI bus, but this will soon
change and the test will be updated.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++
...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 +++++++++++++++++++
.../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++
tests/qemuxmlconftest.c | 1 +
4 files changed, 172 insertions(+)
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.args
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.xml
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.xml
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.args b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.args
new file mode 100644
index 0000000000..9704d7d5e9
--- /dev/null
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.args
@@ -0,0 +1,41 @@
+LC_ALL=C \
+PATH=/bin \
+HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1 \
+USER=test \
+LOGNAME=test \
+XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.local/share \
+XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.cache \
+XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \
+/usr/bin/qemu-system-s390x \
+-name guest=QEMUGuest1,debug-threads=on \
+-S \
+-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \
+-machine s390-ccw-virtio,usb=off,dump-guest-core=off \
+-accel kvm \
+-cpu gen16a-base \
+-m size=2095104k,maxmem=1099511627776k \
+-overcommit mem-lock=off \
+-smp 2,sockets=2,cores=1,threads=1 \
+-object '{"qom-type":"memory-backend-ram","id":"ram-node0","size":2145386496}' \
+-numa node,nodeid=0,cpus=0-1,memdev=ram-node0 \
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
+-display none \
+-no-user-config \
+-nodefaults \
+-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
+-mon chardev=charmonitor,id=monitor,mode=control \
+-rtc base=utc \
+-no-shutdown \
+-boot strict=on \
+-device '{"driver":"zpci","uid":1,"fid":0,"target":"pci.1","id":"zpci1"}' \
+-device '{"driver":"pci-bridge","chassis_nr":1,"id":"pci.1","bus":"pci.0","addr":"0x1"}' \
+-object '{"qom-type":"memory-backend-ram","id":"memvirtiomem0","reserve":false,"size":1073741824}' \
+-device '{"driver":"virtio-mem-pci","node":0,"block-size":2097152,"requested-size":536870912,"memdev":"memvirtiomem0","id":"virtiomem0","bus":"pci.0","addr":"0x2"}' \
+-object '{"qom-type":"memory-backend-file","id":"memvirtiomem1","mem-path":"/dev/hugepages2M/libvirt/qemu/-1-QEMUGuest1","reserve":false,"size":2147483648,"host-nodes":[1,2,3],"policy":"bind"}' \
+-device '{"driver":"virtio-mem-pci","node":0,"block-size":2097152,"requested-size":1073741824,"memdev":"memvirtiomem1","prealloc":true,"memaddr":5637144576,"dynamic-memslots":true,"id":"virtiomem1","bus":"pci.1","addr":"0x1"}' \
+-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-1-storage","read-only":false}' \
+-device '{"driver":"virtio-blk-ccw","devno":"fe.0.0000","drive":"libvirt-1-storage","id":"virtio-disk0","bootindex":1}' \
+-audiodev '{"id":"audio1","driver":"none"}' \
+-device '{"driver":"virtio-balloon-ccw","id":"balloon0","devno":"fe.0.0001"}' \
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
+-msg timestamp=on
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.xml b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.xml
new file mode 100644
index 0000000000..336c6e5aac
--- /dev/null
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.xml
@@ -0,0 +1,71 @@
+<domain type='kvm'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <maxMemory unit='KiB'>1099511627776</maxMemory>
+ <memory unit='KiB'>8388608</memory>
+ <currentMemory unit='KiB'>8388608</currentMemory>
+ <vcpu placement='static' cpuset='0-1'>2</vcpu>
+ <os>
+ <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <cpu mode='custom' match='exact' check='none'>
+ <model fallback='forbid'>gen16a-base</model>
+ <numa>
+ <cell id='0' cpus='0-1' memory='2095104' unit='KiB'/>
+ </numa>
+ </cpu>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-s390x</emulator>
+ <disk type='block' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source dev='/dev/HostVG/QEMUGuest1'/>
+ <target dev='hda' bus='virtio'/>
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
+ </disk>
+ <controller type='pci' index='0' model='pci-root'/>
+ <controller type='pci' index='1' model='pci-bridge'>
+ <model name='pci-bridge'/>
+ <target chassisNr='1'/>
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'>
+ <zpci uid='0x0001' fid='0x00000000'/>
+ </address>
+ </controller>
+ <audio id='1' type='none'/>
+ <memballoon model='virtio'>
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0001'/>
+ </memballoon>
+ <panic model='s390'/>
+ <memory model='virtio-mem'>
+ <target>
+ <size unit='KiB'>1048576</size>
+ <node>0</node>
+ <block unit='KiB'>2048</block>
+ <requested unit='KiB'>524288</requested>
+ </target>
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'>
+ <zpci uid='0x0002' fid='0x00000001'/>
+ </address>
+ </memory>
+ <memory model='virtio-mem'>
+ <source>
+ <nodemask>1-3</nodemask>
+ <pagesize unit='KiB'>2048</pagesize>
+ </source>
+ <target dynamicMemslots='yes'>
+ <size unit='KiB'>2097152</size>
+ <node>0</node>
+ <block unit='KiB'>2048</block>
+ <requested unit='KiB'>1048576</requested>
+ <address base='0x150000000'/>
+ </target>
+ <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'>
+ <zpci uid='0x0003' fid='0x00000002'/>
+ </address>
+ </memory>
+ </devices>
+</domain>
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.xml b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.xml
new file mode 100644
index 0000000000..747877042a
--- /dev/null
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.xml
@@ -0,0 +1,59 @@
+<domain type='kvm'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <maxMemory unit='KiB'>1099511627776</maxMemory>
+ <memory unit='KiB'>8388608</memory>
+ <currentMemory unit='KiB'>8388608</currentMemory>
+ <vcpu placement='static' cpuset='0-1'>2</vcpu>
+ <os>
+ <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <cpu mode='custom' match='exact' check='none'>
+ <model fallback='forbid'>gen16a-base</model>
+ <numa>
+ <cell id='0' cpus='0-1' memory='2095104' unit='KiB'/>
+ </numa>
+ </cpu>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-s390x</emulator>
+ <disk type='block' device='disk'>
+ <driver name='qemu' type='raw'/>
+ <source dev='/dev/HostVG/QEMUGuest1'/>
+ <target dev='hda' bus='virtio'/>
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
+ </disk>
+ <controller type='pci' index='0' model='pci-root'/>
+ <audio id='1' type='none'/>
+ <memballoon model='virtio'>
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0001'/>
+ </memballoon>
+ <memory model='virtio-mem'>
+ <target>
+ <size unit='KiB'>1048576</size>
+ <node>0</node>
+ <block unit='KiB'>2048</block>
+ <requested unit='KiB'>524288</requested>
+ </target>
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
+ </memory>
+ <memory model='virtio-mem'>
+ <source>
+ <nodemask>1-3</nodemask>
+ <pagesize unit='KiB'>2048</pagesize>
+ </source>
+ <target dynamicMemslots='yes'>
+ <size unit='KiB'>2097152</size>
+ <node>0</node>
+ <block unit='KiB'>2048</block>
+ <requested unit='KiB'>1048576</requested>
+ <address base='0x150000000'/>
+ </target>
+ <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
+ </memory>
+ </devices>
+</domain>
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index 5c95a49116..f41e39e313 100644
--- a/tests/qemuxmlconftest.c
+++ b/tests/qemuxmlconftest.c
@@ -2713,6 +2713,7 @@ mymain(void)
* virDomainMemoryDefCheckConflict() works for NVDIMMs which are special
* than other memory devices because of how they handle <labelsize/> */
DO_TEST_CAPS_LATEST("memory-hotplug-nvdimm-overlap");
+ DO_TEST_CAPS_ARCH_LATEST("memory-hotplug-virtio-mem-s390x", "s390x");
DO_TEST_CAPS_ARCH_LATEST("machine-aeskeywrap-on-caps", "s390x");
DO_TEST_CAPS_ARCH_LATEST("machine-aeskeywrap-on-cap", "s390x");
--
2.45.2On 1/24/25 13:21, Michal Privoznik wrote:
> This is an example test for virtio-mem on s390. Currently, both
> virtio-mem devices are placed onto PCI bus, but this will soon
> change and the test will be updated.
>
> Signed-off-by: Michal Privoznik<mprivozn@redhat.com>
> ---
> ...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++
> ...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 +++++++++++++++++++
> .../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++
> tests/qemuxmlconftest.c | 1 +
> 4 files changed, 172 insertions(+)
> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.args
> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.s390x-latest.xml
> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-s390x.xml
I guess with David's response to patch 7 this should not be possible but
currently is because of recorded
tests/qemucapabilitiesdata/caps_10.0.0_s390x.replies file of qemu
v9.2.0-1203-gd6430c17d7.
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On 1/27/25 13:42, Boris Fiuczynski wrote: > On 1/24/25 13:21, Michal Privoznik wrote: >> This is an example test for virtio-mem on s390. Currently, both >> virtio-mem devices are placed onto PCI bus, but this will soon >> change and the test will be updated. >> >> Signed-off-by: Michal Privoznik<mprivozn@redhat.com> >> --- >> ...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++ >> ...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 +++++++++++++++++++ >> .../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++ >> tests/qemuxmlconftest.c | 1 + >> 4 files changed, 172 insertions(+) >> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >> s390x.s390x-latest.args >> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >> s390x.s390x-latest.xml >> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >> s390x.xml > > I guess with David's response to patch 7 this should not be possible but > currently is because of recorded tests/qemucapabilitiesdata/ > caps_10.0.0_s390x.replies file of qemu v9.2.0-1203-gd6430c17d7. > Yeah, trying to start such domain results in QEMU throwing an error: qemu-system-s390x: -device virtio-mem-pci: PCI-attached virtio based memory devices not supported But the point of this patch is to make it more obvious how virtio-mem-ccw is configured (patch 7/8). Michal
On 1/27/25 15:34, Michal Prívozník wrote:
> On 1/27/25 13:42, Boris Fiuczynski wrote:
>> On 1/24/25 13:21, Michal Privoznik wrote:
>>> This is an example test for virtio-mem on s390. Currently, both
>>> virtio-mem devices are placed onto PCI bus, but this will soon
>>> change and the test will be updated.
>>>
>>> Signed-off-by: Michal Privoznik<mprivozn@redhat.com>
>>> ---
>>> ...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++
>>> ...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 +++++++++++++++++++
>>> .../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++
>>> tests/qemuxmlconftest.c | 1 +
>>> 4 files changed, 172 insertions(+)
>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>>> s390x.s390x-latest.args
>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>>> s390x.s390x-latest.xml
>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-
>>> s390x.xml
>>
>> I guess with David's response to patch 7 this should not be possible but
>> currently is because of recorded tests/qemucapabilitiesdata/
>> caps_10.0.0_s390x.replies file of qemu v9.2.0-1203-gd6430c17d7.
>>
>
> Yeah, trying to start such domain results in QEMU throwing an error:
>
> qemu-system-s390x: -device virtio-mem-pci: PCI-attached virtio based
> memory devices not supported
>
> But the point of this patch is to make it more obvious how
> virtio-mem-ccw is configured (patch 7/8).
>
> Michal
Looks like the virtio-mem-pci device test should remain and another test
virtio-mem-ccw should be added in patch 7. I suggest to adjust the test
name(s).
With that
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
--
Mit freundlichen Grüßen/Kind regards
Boris Fiuczynski
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
On 1/27/25 15:46, Boris Fiuczynski wrote: > On 1/27/25 15:34, Michal Prívozník wrote: >> On 1/27/25 13:42, Boris Fiuczynski wrote: >>> On 1/24/25 13:21, Michal Privoznik wrote: >>>> This is an example test for virtio-mem on s390. Currently, both >>>> virtio-mem devices are placed onto PCI bus, but this will soon >>>> change and the test will be updated. >>>> >>>> Signed-off-by: Michal Privoznik<mprivozn@redhat.com> >>>> --- >>>> ...hotplug-virtio-mem-s390x.s390x-latest.args | 41 +++++++++++ >>>> ...-hotplug-virtio-mem-s390x.s390x-latest.xml | 71 ++++++++++++++ >>>> +++++ >>>> .../memory-hotplug-virtio-mem-s390x.xml | 59 +++++++++++++++ >>>> tests/qemuxmlconftest.c | 1 + >>>> 4 files changed, 172 insertions(+) >>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >>>> s390x.s390x-latest.args >>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >>>> s390x.s390x-latest.xml >>>> create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem- >>>> s390x.xml >>> >>> I guess with David's response to patch 7 this should not be possible but >>> currently is because of recorded tests/qemucapabilitiesdata/ >>> caps_10.0.0_s390x.replies file of qemu v9.2.0-1203-gd6430c17d7. >>> >> >> Yeah, trying to start such domain results in QEMU throwing an error: >> >> qemu-system-s390x: -device virtio-mem-pci: PCI-attached virtio based >> memory devices not supported >> >> But the point of this patch is to make it more obvious how >> virtio-mem-ccw is configured (patch 7/8). >> >> Michal > > Looks like the virtio-mem-pci device test should remain and another test > virtio-mem-ccw should be added in patch 7. I suggest to adjust the test > name(s). Yeah, fair enough. So let's wait a bit and see how David's patches end up. After I'll probably respin with v2 (and introduce two test cases). > > With that > Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com> > Thanks! Michal
© 2016 - 2025 Red Hat, Inc.