[PATCH v2 01/36] cpu_x86: Annotate virCPUx86Model fields

Jiri Denemark posted 36 patches 1 week, 4 days ago
[PATCH v2 01/36] cpu_x86: Annotate virCPUx86Model fields
Posted by Jiri Denemark 1 week, 4 days ago
Document which fields are inherited when a CPU model is based on another
model.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---

Notes:
    Version 2:
    - new patch

 src/cpu/cpu_x86.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 97d6e00007..37f3b6e3ce 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -147,13 +147,21 @@ struct _virCPUx86Signatures {
 
 typedef struct _virCPUx86Model virCPUx86Model;
 struct _virCPUx86Model {
+    /* Not inherited from ancestor */
     char *name;
+    /* Not inherited from ancestor */
     bool decodeHost;
+    /* Not inherited from ancestor */
     bool decodeGuest;
+    /* Not inherited from ancestor */
     bool compatCheck;
+    /* Inherited from ancestor */
     virCPUx86Vendor *vendor;
+    /* Inherited from ancestor */
     virCPUx86Signatures *signatures;
+    /* Inherited from ancestor */
     virCPUx86Data data;
+    /* Not inherited from ancestor */
     GStrv removedFeatures;
 
     /* Features added to the CPU model after its original version was released.
@@ -164,6 +172,7 @@ struct _virCPUx86Model {
      * included in the CPU model by the hypervisor, but libvirt didn't support
      * them when introducing the CPU model. In other words, they were enabled,
      * but we ignored them.
+     * Not inherited from ancestor.
      */
     GStrv addedFeatures;
 };
-- 
2.47.0
Re: [PATCH v2 01/36] cpu_x86: Annotate virCPUx86Model fields
Posted by Daniel P. Berrangé 1 week, 1 day ago
On Fri, Nov 22, 2024 at 10:32:41PM +0100, Jiri Denemark wrote:
> Document which fields are inherited when a CPU model is based on another
> model.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|