[PATCH 02/32] sync_qemu_features_i386: Add some removed features back

Jiri Denemark posted 32 patches 2 weeks ago
There is a newer version of this series
[PATCH 02/32] sync_qemu_features_i386: Add some removed features back
Posted by Jiri Denemark 2 weeks ago
When removing features unknown to QEMU (they have a different name or
are completely missing as they are not configurable by a user) I should
not have removed them from the list of features unknown to QEMU in the
script for synchronizing QEMU features to the CPU map.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---
 src/cpu_map/sync_qemu_features_i386.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/cpu_map/sync_qemu_features_i386.py b/src/cpu_map/sync_qemu_features_i386.py
index 15a7af85cb..21df37e9d6 100755
--- a/src/cpu_map/sync_qemu_features_i386.py
+++ b/src/cpu_map/sync_qemu_features_i386.py
@@ -70,6 +70,9 @@ FEATURES_EXTRA = {
         18: "cvt16",
     },
     (0x0000048c,): {
+        8: "vmx-ept-uc",
+        14: "vmx-ept-wb",
+        41: "vmx-invvpid-single-context",               # wrong name in qemu
         43: "vmx-invvpid-single-context-noglobals",     # wrong name in qemu
     }
 }
-- 
2.47.0
Re: [PATCH 02/32] sync_qemu_features_i386: Add some removed features back
Posted by Daniel P. Berrangé 1 week, 6 days ago
On Tue, Nov 19, 2024 at 07:49:38PM +0100, Jiri Denemark wrote:
> When removing features unknown to QEMU (they have a different name or
> are completely missing as they are not configurable by a user) I should
> not have removed them from the list of features unknown to QEMU in the
> script for synchronizing QEMU features to the CPU map.
> 
> Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
> ---
>  src/cpu_map/sync_qemu_features_i386.py | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|