Do not try hot(un)plugging platform char devices

[PATCH 0/3] Do not try hot(un)plugging platform char devices

Posted by Martin Kletzander 1 week, 3 days ago

Just don't.

Martin Kletzander (3):
  qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
  qemu_hotplug: Report better error message for platform serial devices
  qemu_hotplug: Do not report error for hot-unplugging non-existing
    device

 src/qemu/qemu_command.c |  2 +-
 src/qemu/qemu_command.h |  5 +++++
 src/qemu/qemu_hotplug.c | 13 +++++++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)

-- 
2.47.0

Re: [PATCH 0/3] Do not try hot(un)plugging platform char devices

Posted by Peter Krempa 1 week, 3 days ago

On Mon, Nov 11, 2024 at 09:53:06 +0100, Martin Kletzander wrote:
> Just don't.
> 
> Martin Kletzander (3):
>   qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
>   qemu_hotplug: Report better error message for platform serial devices

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

>   qemu_hotplug: Do not report error for hot-unplugging non-existing
>     device

And if you agree with checking -2 in the callers instead also here:

Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Re: [PATCH 0/3] Do not try hot(un)plugging platform char devices

Posted by Martin Kletzander 1 week, 2 days ago

On Mon, Nov 11, 2024 at 10:11:36AM +0100, Peter Krempa wrote:
>On Mon, Nov 11, 2024 at 09:53:06 +0100, Martin Kletzander wrote:
>> Just don't.
>>
>> Martin Kletzander (3):
>>   qemu: Expose qemuChrIsPlatformDevice outside from qemu_command
>>   qemu_hotplug: Report better error message for platform serial devices
>
>Reviewed-by: Peter Krempa <pkrempa@redhat.com>
>

I pushed these two, thank you.

>>   qemu_hotplug: Do not report error for hot-unplugging non-existing
>>     device
>
>And if you agree with checking -2 in the callers instead also here:
>

To make sure I do that properly I'll send another version of this patch.

>Reviewed-by: Peter Krempa <pkrempa@redhat.com>
>